Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

preparations for js-ipfs 0.29.0 #43

Closed
daviddias opened this issue May 28, 2018 · 2 comments
Closed

preparations for js-ipfs 0.29.0 #43

daviddias opened this issue May 28, 2018 · 2 comments

Comments

@daviddias
Copy link
Member

I've run the tests of this module in preparation for ipfs/js-ipfs#1320.

All of the tests pass, however, note that the PubSub API did change, consider updating carefully.
@daviddias daviddias changed the title preparations for 0.29.0 preparations for js-ipfs 0.29.0 May 28, 2018
@daviddias daviddias mentioned this issue May 28, 2018
Closed
30 tasks
@alanshaw
Copy link
Member

WRT the change to pubsub.subscribe this module won't be affected as it does not use the options object.

With pubsub.unsubscribe becoming async, some refactoring will need to take place because when "leave" is called, the room won't be fully unsubscribed when the "stop" event is fired.

@pgte pgte closed this as completed in ce98f31 Jun 1, 2018
@pgte
Copy link
Contributor

pgte commented Jun 1, 2018

@alanshaw thanks!

Support for this landed on v1.3.0.

@daviddias daviddias mentioned this issue Jul 6, 2018
Closed
23 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@pgte @alanshaw @daviddias