feat: support custom config for ipfs-http-client #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds tests for passing an object with custom config for ipfs-http-client. It is useful if API is protected by basic auth, bearer token or custom HTTP header. License: MIT Signed-off-by: Marcin Rataj <[email protected]>
lidel
force-pushed
the
feat/basic-auth-support
branch
from
2055b0a
to
c07aff0
Compare
lidel
commented
Sep 9, 2020
| // Returns js-ipfs-http-client instance or null | ||
| async function maybeApi ({ apiAddress, connectionTest, httpClient }) { | ||
| try { | ||
| const ipfs = httpClient(apiAddress) | ||
| const ipfs = httpClient(copyIfObject(apiAddress)) |
There was a problem hiding this comment.
👉 This is literally the only code change in this PR, everything else is docs and updated comments. :-)
Making it work with latest JS API License: MIT Signed-off-by: Marcin Rataj <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds tests and hardening necessary for passing an object with custom config for ipfs-http-client in
apiAddress.It is useful if API is protected by basic auth, bearer token or custom HTTP header.
Goal is to make ipfs/ipfs-webui#1613 more future-proof.