ipfs.add should always return same type

[victorb]

ipfs.add have a kind of confused API (the same with some other methods), that it's sometimes returning a stream and sometimes an object. I think this is because of the environment but we should try to make sure that inside the callback, users don't have to try to figure out what type it is, it should always be the same type.

Will also help simplifying the tests for browser/node environments.

[dignifiedquire]

👍

[victorb]

I see now that ipfs.add is not the only command that works this way. ipfs.object.data, ipfs.cat and ipfs.block.get would need to be fixed as well.

[daviddias]

with the update to 0.3.8, IPFS started returning ndjson on the HTTP API instead of a JSON array, we need to update that on the node-ipfs-api

[daviddias]

@victorbjelkholm can you confirm if this is still a problem this? The distinction between a stream and an object comes from go-ipfs itself, depending how the header is set:

https://github.com/ipfs/js-ipfs-api/blob/master/src/request-api.js#L63-L64

[dignifiedquire]

According to the tests this should now happen, and will be available for everyone when ipfs/kubo#1979 is merged and released. @victorbjelkholm can you confirm please?