Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/add more metrics #163

Merged
merged 5 commits into from
Dec 7, 2023
Merged

Feat/add more metrics #163

merged 5 commits into from
Dec 7, 2023

Conversation

LinZexiao
Copy link
Collaborator

关联的Issues (Related Issues)

ref filecoin-project/venus#6051

改动 (Proposed Changes)

附注 (Additional Info)

自查清单 (Checklist)

在你认为本 PR 满足被审阅的标准之前,需要确保 / Before you mark the PR ready for review, please make sure that:

  • 符合Venus项目管理规范中关于PR的相关标准 / The PR follows the PR standards set out in the Venus project management guidelines
  • 具有清晰明确的commit message / All commits have a clear commit message.
  • 包含相关的的测试用例或者不需要新增测试用例 / This PR has tests for new functionality or change in behaviour or not need to add new tests.
  • 包含相关的的指南以及文档或者不需要新增文档 / This PR has updated usage guidelines and documentation or not need
  • 通过必要的检查项 / All checks are green

@LinZexiao LinZexiao force-pushed the feat/add-more-metrics branch from 110a369 to 157d4f4 Compare December 7, 2023 05:56
@LinZexiao LinZexiao force-pushed the feat/add-more-metrics branch from 157d4f4 to c970795 Compare December 7, 2023 08:18
@codecov-commenter
Copy link

Codecov Report

Merging #163 (c970795) into master (08ab3ab) will increase coverage by 1.04%.
The diff coverage is 31.03%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #163      +/-   ##
==========================================
+ Coverage   70.60%   71.65%   +1.04%     
==========================================
  Files          26       26              
  Lines        1987     1972      -15     
==========================================
+ Hits         1403     1413      +10     
+ Misses        514      490      -24     
+ Partials       70       69       -1     
Flag Coverage Δ
unittests 71.65% <31.03%> (+1.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
marketevent/market_event.go 91.15% <100.00%> (ø)
metrics/metrics.go 100.00% <100.00%> (ø)
proofevent/proof_event.go 90.44% <100.00%> (ø)
walletevent/wallet_event.go 74.12% <ø> (-0.18%) ⬇️
metrics/exporter.go 57.14% <33.33%> (+27.51%) ⬆️
metrics/record_metrics_loop.go 13.63% <0.00%> (+13.63%) ⬆️

... and 3 files with indirect coverage changes

Copy link
Collaborator

@simlecode simlecode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@simlecode simlecode merged commit 52578e5 into master Dec 7, 2023
1 check passed
@simlecode simlecode deleted the feat/add-more-metrics branch December 7, 2023 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants