Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(worker): correctly parsing URLs with hostnames #691

Merged
merged 1 commit into from
Apr 18, 2023

Conversation

0x5459
Copy link
Collaborator

@0x5459 0x5459 commented Apr 17, 2023

关联的Issues (Related Issues)

改动 (Proposed Changes)

修复当worker中配置 vsm rpc地址时填入域名时无法正确解析的问题

附注 (Additional Info)

自查清单 (Checklist)

在你认为本 PR 满足被审阅的标准之前,需要确保 / Before you mark the PR ready for review, please make sure that:

  • 符合 Venus 项目管理规范中关于 PR 的相关标准 / The PR follows the PR standards set out in the Venus project management guidelines
  • 具有清晰明确的 commit message / All commits have a clear commit message.
  • 包含相关的的测试用例或者不需要新增测试用例 / This PR has tests for new functionality or change in behaviour or not need to add new tests.
  • 包含相关的的指南以及文档或者不需要新增文档 / This PR has updated usage guidelines and documentation or not need
  • 通过必要的检查项 / All checks are green

@0x5459 0x5459 added needs-cherry-pick-0.6 Need cherry pick to release 0.6 bug Something isn't working labels Apr 17, 2023
@0x5459 0x5459 mentioned this pull request Apr 17, 2023
5 tasks
@0x5459 0x5459 force-pushed the fix/0x5459/support_host_in_rpc_addr branch from 3586180 to 544d9ad Compare April 17, 2023 10:09
@0x5459 0x5459 mentioned this pull request Apr 17, 2023
5 tasks
Copy link
Collaborator

@LinZexiao LinZexiao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@LinZexiao LinZexiao merged commit 5ba1ef8 into main Apr 18, 2023
@LinZexiao LinZexiao deleted the fix/0x5459/support_host_in_rpc_addr branch April 18, 2023 05:08
LinZexiao added a commit that referenced this pull request Apr 18, 2023
@0x5459 0x5459 mentioned this pull request Apr 20, 2023
37 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working needs-cherry-pick-0.6 Need cherry pick to release 0.6
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants