buildTrunkPackage fails with trunk from nixpkgs

[antifuchs]

Describe the bug

Using buildTrunkPackage with trunk 0.21.1 from nixpkgs-unstable results in an unfortunate error when the profile that's being built is release:

Running phase: buildPhase
@nix { "action": "setPhase", "phase": "buildPhase" }
++ command cargo --version
cargo 1.82.0 (8f40fc59f 2024-08-21)
error: invalid value './index.html' for '--release [<RELEASE>]'
  [possible values: true, false]

That's because buildTrunkPackage passes --release (here) and trunk requires --release=true now (I suspect introduced in this change).

I've reported this to the trunk maintainers at trunk-rs/trunk#908, but I suspect crane might want to switch to --release=true instead. What do you think?

Reproduction

Using the example from https://crane.dev/examples/trunk.html with a trunk from this nixpkgs change: NixOS/nixpkgs@fdd01fd reproduces the issue.

[antifuchs]

And oops, trunk 0.20.1 (in nixpkgs release 24.05) doesn't allow --release=true. Ugh.

[ipetkov]

Hi @antifuchs thanks for the report, should be easy enough to conditionally set =true if the trunk version is >= 0.21!

Will be fixed with #736

[antifuchs]

Awesome, that works for me! Thank you (: