Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bleeding edge, or released version? #9

Closed
gavanderhoorn opened this issue Sep 5, 2019 · 3 comments
Closed

Bleeding edge, or released version? #9

gavanderhoorn opened this issue Sep 5, 2019 · 3 comments

Comments

@gavanderhoorn
Copy link

The readme status:

This repository wraps the bleeding edge versions of pybind11 for use in catkin-based projects.

But CMakeLists.txt appears to actually package version 2.2.4.

I'm actually happy it's not fetching master or something similar, but just for clarification: you're tracking upstream with this package, but packaging a newer version is only done if/when a human decides to fetch the newer release archive.

Correct?

@wxmerkt
Copy link
Owner

wxmerkt commented Sep 5, 2019

Hi @gavanderhoorn,
Yes, correct. I will amend the README. We packaged 2.2.4 as it contains the Eigen<>NumPy fixes and updates that aren't in the bionic-released debian yet. We haven't tracked newer versions yet. Would you like me to make a new release with the most recent release?

@gavanderhoorn
Copy link
Author

Would you like me to make a new release with the most recent release?

No, I'm fine with 2.2.4 personally. Just wanted to make sure I didn't misunderstand the readme/CMakeLists.txt.

@gavanderhoorn
Copy link
Author

Thanks for clearing this up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants