Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore DESTDIR for the internal ExternalProject_Add() command #19

Merged
merged 1 commit into from
Feb 9, 2023

Conversation

meyerj
Copy link
Contributor

@meyerj meyerj commented Jul 11, 2022

... using the solution suggested in https://gitlab.kitware.com/cmake/cmake/-/issues/18165.

This works for me. Without having read the complete thread, this approach likely also fixes #16.

Copy link
Owner

@wxmerkt wxmerkt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the fix!

@wxmerkt wxmerkt closed this Feb 9, 2023
@wxmerkt wxmerkt reopened this Feb 9, 2023
@wxmerkt
Copy link
Owner

wxmerkt commented Feb 9, 2023

Reopening to trigger newly added CI

@wxmerkt wxmerkt merged commit bdf3a36 into wxmerkt:master Feb 9, 2023
@meyerj meyerj deleted the fix/destdir-support branch January 5, 2024 00:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fails to install FindPythonLibNew.cmake when specifying DESTDIR
2 participants