-
Notifications
You must be signed in to change notification settings - Fork 166
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Build ubuntu image and use them instead of alpine #52
Conversation
a62df10
to
4687eef
Compare
Looks like I broke CI with this ,will need to see what's up later (train wifi is garbage). Testing this out locally and seems to work. My approach was to leave the alpine build, and use dependencies to target which build should actually be done in the makefile. This should allow for keeping the alpine image up to date easily. I moved all the dockerfiles to the build directory as well. |
The commit history is ugly, i'll rebase before merging if the changes are approved. |
4438f2e
to
7434747
Compare
Assigned to me to continue work: Tasks:
|
@leodido PTAL |
Signed-off-by: Lorenzo Fontana <[email protected]>
Signed-off-by: Lorenzo Fontana <[email protected]>
Signed-off-by: Leonardo Di Donato <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Dale!
This looks sooo good to me! 🎉
Thanks guys! |
Fix for #51 and also bumps bpftrace to 0.9.2 from ubuntu eaon
I was able to confirm that the script that doesn't work with static bpftrace works with the dynamically linked one. This is at the expense of a slightly larger (well, 3x larger), though the size here shouldn't matter too much.
As I state in #51, the preferred solution would be to fix the static alpine build (no idea how to do this), or get a static build for ubuntu working (should be possible, others are working on it).
This could at least be a stop-gap until there's a working/non-crashy static image available