fix(cmd/tracerunner): fix signal handling in trace attach #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Lorenzo Fontana <[email protected]>
alban
previously approved these changes
Jan 14, 2019
There was a problem hiding this comment.
One comment, but looks good otherwise.
If I understand correctly, ctrl-c on the terminal will send SIGINT to all the processes attached to the terminal: both tracerunner and bpftrace. Upon reception, tracerunner will ignore it at first and bpftrace will exit gracefully. When received a second time, tracerunner will kill bpftrace.
I wanted to test it, but I couldn't build the docker image (make image/build) because of the ARG before FROM. It seems to be moby/moby#31352. I am trying to upgrade...
Signed-off-by: Lorenzo Fontana <[email protected]>
|
Thanks for the review @alban - merging this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@alban found this bug, sending a fix.
The problem is that after switching to tracerunner the tty didn't work as expected because the signals where not handled.
Signed-off-by: Lorenzo Fontana [email protected]