Skip to content

Commit fdb48c8

Browse files
fntlnzleodido
authored andcommitted
new(build): make sure we only build with the specified bpftrace version
Signed-off-by: Lorenzo Fontana <[email protected]>
1 parent 9582b4f commit fdb48c8

File tree

2 files changed

+6
-3
lines changed

2 files changed

+6
-3
lines changed

Makefile

+3
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,8 @@ IMAGE_INITCONTAINER_LATEST := $(IMAGE_NAME_INIT):latest
2020

2121
IMAGE_BUILD_FLAGS ?= "--no-cache"
2222

23+
BPFTRACEVERSION ?= "0.9.2-1"
24+
2325
LDFLAGS := -ldflags '-X github.com/iovisor/kubectl-trace/pkg/version.buildTime=$(shell date +%s) -X github.com/iovisor/kubectl-trace/pkg/version.gitCommit=${GIT_COMMIT} -X github.com/iovisor/kubectl-trace/pkg/cmd.ImageNameTag=${IMAGE_TRACERUNNER_COMMIT} -X github.com/iovisor/kubectl-trace/pkg/cmd.InitImageNameTag=${IMAGE_INITCONTAINER_COMMIT}'
2426
TESTPACKAGES := $(shell go list ./... | grep -v github.com/iovisor/kubectl-trace/integration)
2527

@@ -50,6 +52,7 @@ image/build-init:
5052
.PHONY: image/build
5153
image/build:
5254
$(DOCKER) build \
55+
--build-arg bpftraceversion=$(BPFTRACEVERSION) \
5356
$(IMAGE_BUILD_FLAGS) \
5457
-t "$(IMAGE_TRACERUNNER_BRANCH)" \
5558
-f build/Dockerfile.tracerunner .

build/Dockerfile.tracerunner

+3-3
Original file line numberDiff line numberDiff line change
@@ -9,9 +9,9 @@ WORKDIR /go/src/github.com/iovisor/kubectl-trace
99
RUN make _output/bin/trace-runner
1010

1111
FROM ubuntu:19.10
12-
13-
RUN apt-get update && apt-get install -y bpftrace && \
14-
rm -rf /var/lib/apt/lists/* && apt-get clean
12+
ARG bpftraceversion=0.9.2-1
13+
RUN apt-get update && apt-get install -y bpftrace=${bpftraceversion} && \
14+
rm -rf /var/lib/apt/lists/* && apt-get clean
1515

1616
COPY --from=gobuilder /go/src/github.com/iovisor/kubectl-trace/_output/bin/trace-runner /bin/trace-runner
1717

0 commit comments

Comments
 (0)