Merge pull request #89 from jerr/fix-no-starttime-case

fix: no job start time case
iovisor · Sep 18, 2019 · ccbe98a · ccbe98a
2 parents 69c91c8 + 4ff6355
commit ccbe98a
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/pkg/cmd/get.go b/pkg/cmd/get.go
@@ -200,7 +200,7 @@ func jobsTablePrint(o io.Writer, jobs []tracejob.TraceJob) {
 
 // translateTimestampSince returns the elapsed time since timestamp in
 // human-readable approximation.
-func translateTimestampSince(timestamp metav1.Time) string {
+func translateTimestampSince(timestamp *metav1.Time) string {
 	if timestamp.IsZero() {
 		return "<unknown>"
 	}

diff --git a/pkg/tracejob/job.go b/pkg/tracejob/job.go
@@ -35,7 +35,7 @@ type TraceJob struct {
 	ImageNameTag     string
 	InitImageNameTag string
 	FetchHeaders     bool
-	StartTime        metav1.Time
+	StartTime        *metav1.Time
 	Status           TraceJobStatus
 }
 
@@ -131,7 +131,7 @@ func (t *TraceJobClient) GetJob(nf TraceJobFilter) ([]TraceJob, error) {
 			ID:        types.UID(id),
 			Namespace: j.Namespace,
 			Hostname:  hostname,
-			StartTime: *j.Status.StartTime,
+			StartTime: j.Status.StartTime,
 			Status:    jobStatus(j),
 		}
 		tjobs = append(tjobs, tj)