Merge pull request #62 from jerr/log-cmd-for-completed-job

fntlnz · web-flow · commit cbb07adb8906 · 2019-02-28T12:55:19.000+01:00
fix: Accept completed job for log command
diff --git a/pkg/logs/logs.go b/pkg/logs/logs.go
@@ -47,7 +47,7 @@ func (l *Logs) Run(jobID types.UID, namespace string, follow bool, timestamps bo
 	}
 
 	pod := &pl.Items[0]
-	if pod.Status.Phase == corev1.PodSucceeded || pod.Status.Phase == corev1.PodFailed {
+	if pod.Status.Phase == corev1.PodFailed {
 		return fmt.Errorf(podPhaseNotAcceptedError, pod.Status.Phase)
 	}
 

Original file line number	Diff line number	Diff line change
`@@ -47,7 +47,7 @@ func (l *Logs) Run(jobID types.UID, namespace string, follow bool, timestamps bo`
`47`	`47`	`}`
`48`	`48`
`49`	`49`	`pod := &pl.Items[0]`
`50`		`- if pod.Status.Phase == corev1.PodSucceeded \|\| pod.Status.Phase == corev1.PodFailed {`
	`50`	`+ if pod.Status.Phase == corev1.PodFailed {`
`51`	`51`	`return fmt.Errorf(podPhaseNotAcceptedError, pod.Status.Phase)`
`52`	`52`	`}`
`53`	`53`