From c196818087d55292c24aa5d583648db040b55421 Mon Sep 17 00:00:00 2001
From: Lorenzo Fontana <lo@linux.com>
Date: Thu, 22 Nov 2018 11:01:54 +0100
Subject: [PATCH] feat(pkg/meta): meta package for selector keys

Signed-off-by: Lorenzo Fontana <lo@linux.com>
---
 cmd/kubectl-trace/run.go |  2 +-
 pkg/attacher/attach.go   |  6 +++---
 pkg/meta/constants.go    |  6 ++++++
 pkg/tracejob/job.go      | 11 ++++++-----
 4 files changed, 16 insertions(+), 9 deletions(-)
 create mode 100644 pkg/meta/constants.go

diff --git a/cmd/kubectl-trace/run.go b/cmd/kubectl-trace/run.go
index b9f3f0c0..aa1c57eb 100644
--- a/cmd/kubectl-trace/run.go
+++ b/cmd/kubectl-trace/run.go
@@ -102,7 +102,7 @@ func run(cmd *cobra.Command, args []string) {
 	a.WithLogger(log)
 	a.WithContext(ctx)
 
-	a.AttachJob(job.Name, job.Namespace)
+	a.AttachJob(tj.ID, job.Namespace)
 
 	<-ctx.Done()
 }
diff --git a/pkg/attacher/attach.go b/pkg/attacher/attach.go
index 6d16c93d..b0c9d34c 100644
--- a/pkg/attacher/attach.go
+++ b/pkg/attacher/attach.go
@@ -8,6 +8,7 @@ import (
 	"os"
 	"time"
 
+	"github.com/fntlnz/kubectl-trace/pkg/meta"
 	"go.uber.org/zap"
 	"k8s.io/apimachinery/pkg/util/wait"
 	"k8s.io/client-go/kubernetes/scheme"
@@ -53,14 +54,13 @@ func (a *Attacher) WithContext(c context.Context) {
 	a.ctx = c
 }
 
-func (a *Attacher) AttachJob(jobName, namespace string) {
-	a.Attach(fmt.Sprintf("job-name=%s", jobName), namespace)
+func (a *Attacher) AttachJob(traceJobID string, namespace string) {
+	a.Attach(fmt.Sprintf("%s=%s", meta.TraceIDLabelKey, traceJobID), namespace)
 }
 
 func (a *Attacher) Attach(selector, namespace string) {
 	go wait.PollImmediate(time.Second, 10*time.Second, func() (bool, error) {
 		pl, err := a.CoreV1Client.Pods(namespace).List(metav1.ListOptions{
-			//LabelSelector: "job-name=test-renzo",
 			LabelSelector: selector,
 		})
 
diff --git a/pkg/meta/constants.go b/pkg/meta/constants.go
new file mode 100644
index 00000000..c7f4ec00
--- /dev/null
+++ b/pkg/meta/constants.go
@@ -0,0 +1,6 @@
+package meta
+
+const (
+	TraceIDLabelKey = "fntlnz.wtf/kubectl-trace-id"
+	TraceLabelKey   = "fntlnz.wtf/kubectl-trace"
+)
diff --git a/pkg/tracejob/job.go b/pkg/tracejob/job.go
index 826772c0..4349001d 100644
--- a/pkg/tracejob/job.go
+++ b/pkg/tracejob/job.go
@@ -3,6 +3,7 @@ package tracejob
 import (
 	"fmt"
 
+	"github.com/fntlnz/kubectl-trace/pkg/meta"
 	batchv1 "k8s.io/api/batch/v1"
 	apiv1 "k8s.io/api/core/v1"
 	metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
@@ -25,7 +26,7 @@ type TraceJob struct {
 
 func (t *TraceJobClient) DeleteJob(nj TraceJob) error {
 	selectorOptions := metav1.ListOptions{
-		LabelSelector: fmt.Sprintf("fntlnz.wtf/kubectl-trace-id=%s", nj.ID),
+		LabelSelector: fmt.Sprintf("%s=%s", meta.TraceIDLabelKey, nj.ID),
 	}
 	jl, err := t.JobClient.List(selectorOptions)
 
@@ -71,12 +72,12 @@ func (t *TraceJobClient) CreateJob(nj TraceJob) (*batchv1.Job, error) {
 		Name:      nj.Name,
 		Namespace: nj.Namespace,
 		Labels: map[string]string{
-			"fntlnz.wtf/kubectl-trace":    nj.Name,
-			"fntlnz.wtf/kubectl-trace-id": nj.ID,
+			meta.TraceLabelKey:   nj.Name,
+			meta.TraceIDLabelKey: nj.ID,
 		},
 		Annotations: map[string]string{
-			"fntlnz.wtf/kubectl-trace":    nj.Name,
-			"fntlnz.wtf/kubectl-trace-id": nj.ID,
+			meta.TraceLabelKey:   nj.Name,
+			meta.TraceIDLabelKey: nj.ID,
 		},
 	}