Attacher continues retrying if pod not found

zqureshi · fntlnz · commit 231a6181566c · 2020-11-18T15:44:31.000+01:00
diff --git a/pkg/attacher/attach.go b/pkg/attacher/attach.go
@@ -68,7 +68,9 @@ func (a *Attacher) Attach(selector, namespace string) {
 			}
 
 			if len(pl.Items) == 0 {
-				return false, fmt.Errorf(podNotFoundError)
+				// A job might have been created but the pod scheduling could have been delayed
+				// therefore we cannot simply error out here and must continue retrying.
+				return false, nil
 			}
 			pod := &pl.Items[0]
 			if pod.Status.Phase == corev1.PodSucceeded || pod.Status.Phase == corev1.PodFailed {

Original file line number	Diff line number	Diff line change
`@@ -68,7 +68,9 @@ func (a *Attacher) Attach(selector, namespace string) {`
`68`	`68`	`}`
`69`	`69`
`70`	`70`	`if len(pl.Items) == 0 {`
`71`		`- return false, fmt.Errorf(podNotFoundError)`
	`71`	`+ // A job might have been created but the pod scheduling could have been delayed`
	`72`	`+ // therefore we cannot simply error out here and must continue retrying.`
	`73`	`+ return false, nil`
`72`	`74`	`}`
`73`	`75`	`pod := &pl.Items[0]`
`74`	`76`	`if pod.Status.Phase == corev1.PodSucceeded \|\| pod.Status.Phase == corev1.PodFailed {`