ClangLoader: Pull out common remapped file operations #3566
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davemarchevsky
requested review from
4ast,
drzaeus77 and
yonghong-song
as code owners
I'm making some larger modifications to the loader. While reading through the `do_compile` code I noticed that the common "remapped file" operations - telling various CompilerInvocations about 'virtual' includes and the virtual main c file - could be factored out to enhance clarity. This patch doesn't change functionality at all, nor does it try to make any opinionated refactoring changes.
davemarchevsky
force-pushed
the
davemarchevsky_remapped_refactor
branch
from
2e4bb09 to
c8d65dc
Compare
|
[buildbot, test this please] |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm making some larger modifications to the loader. While reading
through the
do_compilecode I noticed that the common "remapped file"operations - telling various CompilerInvocations about 'virtual'
includes and the virtual main c file - could be factored out to enhance
clarity.
This patch doesn't change functionality at all, nor does it try to make
any opinionated refactoring changes.