-
Notifications
You must be signed in to change notification settings - Fork 328
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix panic if account error #4521
base: master
Are you sure you want to change the base?
Conversation
api/web3server_utils.go
Outdated
@@ -181,6 +181,9 @@ func (svr *web3Handler) checkContractAddr(to string) (bool, error) { | |||
return false, err | |||
} | |||
accountMeta, _, err := svr.coreService.Account(ioAddr) | |||
if err != nil { | |||
return false, err | |||
} | |||
return accountMeta.IsContract, err |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
return accountMeta.IsContract, nil
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please fix before merge
Quality Gate passedIssues Measures |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4521 +/- ##
==========================================
- Coverage 74.83% 73.10% -1.74%
==========================================
Files 378 384 +6
Lines 31624 32760 +1136
==========================================
+ Hits 23666 23948 +282
- Misses 6747 7580 +833
- Partials 1211 1232 +21 ☔ View full report in Codecov by Sentry. |
Description
as title
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Test Configuration:
Checklist: