feat(protocol): PCR-2 base changes #5270
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 4 Skipped Deployments
|
cyberphysic4l
changed the base branch from
core-protocol/procotol-version-4
to
protocol/pcr2-clean
muXxer
approved these changes
Feb 7, 2025
kodemartin
reviewed
Feb 10, 2025
Contributor
kodemartin
left a comment
kodemartin
left a comment
There was a problem hiding this comment.
Hey @cyberphysic4l , a few nitpicks and a proposal with more impact to discuss.
crates/iota-types/src/iota_system_state/iota_system_state_inner_v2.rs
Outdated
Show resolved
Hide resolved
piotrm50
approved these changes
Feb 12, 2025
valeriyr
reviewed
Feb 12, 2025
kodemartin
reviewed
Feb 13, 2025
crates/iota-types/src/iota_system_state/iota_system_state_summary.rs
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
protocol_defined_base_feeand config parameterbase_gas_price.protocol_defined_base_feeenables the base fee defined bybase_gas_pricein the place of the reference gas price defined by the gas price survey in earlier protocol versions. Thisbase_gas_pricefor each transaction is burned, and any additional gas price will be passed to the validators as a tip.advance_epochfunction in the iota framework is updated to burn the base fee and pass additional fee to validators. The function now takes an additional call argument -computation_charge_burned- to allow the base fee component and tip to be distinguished.IotaSystemStateV2and associated types to include asafe_mode_computation_charges_burnedfield. Some tests are updated to deal with this new system state version. Updates were carried out following the guide provided in crates/iota-framework/packages/iota-system/sources/iota_system.moveChangeEpochV2transaction kind is introduced for the epoch change system transaction corresponding to theadvance_epochfunction changes mentioned above. The new feature flag,protocol_defined_base_feeis used to determined when the newChangeEpochV2transaction kind should be used and the additional call argument be passed to theadvance_epochfunctionSystemEpochInfoEventV2to include thetips_amountfield specifying how much of user computation fees are passed to validators.Links to any relevant issues
Fixes #3122
Should be merged along with iotaledger/iota-rust-sdk#22
Type of change
How the change has been tested
Existing tests pass. Added move tests for tips in
rewards_distribution_tests.moveChange checklist
Tick the boxes that are relevant to your changes, and delete any items that are not.