refactor(iota-types): Remove trait ParentSync #3799
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
muXxer
approved these changes
Oct 30, 2024
alexsporn
approved these changes
Oct 30, 2024
valeriyr
approved these changes
Oct 30, 2024
Thoralf-M
approved these changes
Oct 30, 2024
miker83z
requested changes
Oct 30, 2024
Contributor
miker83z
left a comment
miker83z
left a comment
There was a problem hiding this comment.
Looks good! There is a leftover:
miker83z
approved these changes
Oct 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
Remove the
ParentSynctrait, which only contains a deprecated methodget_latest_parent_entry_ref_deprecated, and eliminate all its implementations.Links to any relevant issues
Part of #2092
Type of change
Change checklist