feat(bindings): Convert some types to remote records and add docs #63
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was
linked to
issues
Jul 30, 2025
Closed
Thoralf-M
reviewed
Jul 30, 2025
Thoralf-M
reviewed
Jul 30, 2025
Thoralf-M
approved these changes
Jul 30, 2025
Alex6323
approved these changes
Jul 30, 2025
thibault-martinez
added a commit
that referenced
this pull request
Aug 7, 2025
* Add bindings crate * fix test * tweaks * remove gate * missing impl and remove another gate * cleanup * clippy * re-add sub feature * feat(bindings): Remove uniffi impls from core crates and use object wrappers (#47) * wrap address * Add more impls * even more * more!!! * fix name value impl * MOREEEE * revert error changes * cleanup * Remove uniffi features * update python bindings * nit * add object IDs to schema * add gas implt * record impl * feat(bindings): Convert some types to remote records and add docs (#63) * feat(bindings): Convert some types to remote records and add docs * update lib * add missing tags * clippy * fix doc * harmony * remove unnecessary flags (again) * nits * more nits * nitttt * refactor typetag methods and add into_opt * rename err * remove derive from * Update crates/iota-sdk-types/Makefile Co-authored-by: Thibault Martinez <[email protected]> * add ci concurrency * remove rest of the derives --------- Co-authored-by: Thoralf Müller <[email protected]> Co-authored-by: Thibault Martinez <[email protected]>
This was
unlinked from
issues
Aug 13, 2025
Closed
howjmay
pushed a commit
to howjmay/iota-rust-sdk
that referenced
this pull request
Oct 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Some types can still be Records, but they have to be redefined in the bindings crates. I added
Fromimpls to convert between them (with the added benefit of verifying them at compile time).In one case,
GasCostSummary, there are only fields that are basic uniffi compatable types so it could be implemented with the remote attribute.Overall this method provides a clean API for users in the case where we do not need associated methods, which is true for many of our structs.
Closes #58 #61 #62