chore: prefer strum::Display over derive_more::Display
#359
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Alex6323
force-pushed
the
chore/derive-strum-display
branch
from
2eba841 to
396befd
Compare
Thoralf-M
approved these changes
Nov 4, 2025
thibault-martinez
changed the title
strum::Display over derive_more::Displaystrum::Display over derive_more::Display
thibault-martinez
approved these changes
Nov 4, 2025
This was referenced Nov 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
derive_more:::Displayforces us to manually define the display representation of each enum variant, which isa) noisy
b) prone to typing (as in hammering the keyboard) errors
c) more work
strumas the#[strum(serialize_all = "...")attribute` which is more convenient for us, and we're also already doing that in many cases, so we remove some inconsistencies.