fix(ffi): do not use as_v1 for Transaction::{to_bcs, to_base64}
#325
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thibault-martinez
changed the title
as_v1 for Transaction::{to_bcs, to_base64}as_v1 for Transaction::{to_bcs, to_base64}
Thoralf-M
approved these changes
Oct 17, 2025
DaughterOfMars
approved these changes
Oct 20, 2025
Alex6323
approved these changes
Oct 20, 2025
This was referenced Nov 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Otherwise it doesn't serialise the type byte and the result is different from what
from_bcsandfrom_base64are expecting, making round trips erroneous.I have tested it with the
dry_run_bytesexample which were producingAAIAIAAApJhL1JXUNG+iCN3/T11eWtSMId7GMd3ryZgJ8WkAAAgA8gUqAQAAAAICAAEBAQABAQIAAAEAAGEYMNNkGmj5SmkNzCXR9LDayUgyWsGPbdMlZDcXNfMsAgsCcO6dJ9oNsJZR5fczjfoyx+5kQczvofbjBXNbz8erczoyHAAAAAAgqUjvvTgfDEQpwAlQNq9jEW4mC+mwXBCS2prf+2sQjifQQHf+O2+tE7PU7Q1TW3ypKvysjw8qDgkl+59PCzDGmXI6MhwAAAAAIHCjhEicUeSyUMVTOcSW1jD849wfgQWjT8C3uQwtmmhwYRgw02QaaPlKaQ3MJdH0sNrJSDJawY9t0yVkNxc18yzoAwAAAAAAAKAtLQAAAAAAAA==instead of
AAACACAAAKSYS9SV1DRvogjd/09dXlrUjCHexjHd68mYCfFpAAAIAPIFKgEAAAACAgABAQEAAQECAAABAABhGDDTZBpo+UppDcwl0fSw2slIMlrBj23TJWQ3FzXzLAILAnDunSfaDbCWUeX3M436MsfuZEHM76H24wVzW8/Hq3M6MhwAAAAAIKlI7704HwxEKcAJUDavYxFuJgvpsFwQktqa3/trEI4n0EB3/jtvrROz1O0NU1t8qSr8rI8PKg4JJfufTwswxplyOjIcAAAAACBwo4RInFHkslDFUznEltYw/OPcH4EFo0/At7kMLZpocGEYMNNkGmj5SmkNzCXR9LDayUgyWsGPbdMlZDcXNfMs6AMAAAAAAACgLS0AAAAAAAA=without this fix.