Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sequencer.push() should return added one's pointer #592

Closed
Rollooo opened this issue Oct 1, 2021 · 1 comment
Closed

sequencer.push() should return added one's pointer #592

Rollooo opened this issue Oct 1, 2021 · 1 comment

Comments

@Rollooo
Copy link

Rollooo commented Oct 1, 2021

Your environment.

  • Version: Latest (Master)
  • Client: Chrome(pubsub test)
  • Environement: OSX
  • Are you using a TURN server? No

What did you do?

Try to check retransmission.

What did you expect?

Set right metadata for vp8 packet

What happened?

sequencer.push() returns next packet metadata.
At DownTrack.writeSimulcastRTP() push packet metadata to sequencer and set vp8 payload metadata.
But at here sequencer.push() returns next packet and set vp8 payload metadata of returned value.

So I think sequencer.push should return added one's pointer.

n.seq[n.step] = packetMeta{
    sourceSeqNo: sn,
    targetSeqNo: offSn,
    timestamp:   timeStamp,
    layer:       layer,
}
n.step++ // I think should store current step before this line
if n.step >= n.max {
n.step = 0
}
return &n.seq[n.step] // Should return added one
@OrlandoCo
Copy link
Collaborator

@Rollooo hey good catch thank you will solve asap!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants