Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FAKE Support] Broken after latest FCS Update #561

Closed
baronfel opened this issue Feb 27, 2020 · 4 comments · Fixed by fsprojects/FAKE#2475
Closed

[FAKE Support] Broken after latest FCS Update #561

baronfel opened this issue Feb 27, 2020 · 4 comments · Fixed by fsprojects/FAKE#2475

Comments

@baronfel
Copy link
Contributor

baronfel commented Feb 27, 2020

Newer FCS versions have introduced new optional parameters to the FSharpChecker.Create call, and the Fake Support uses YaafFSharpScripting which hasn't yet been updated. This means we get the following exception at runtime:

[10:00:04 ERR] [Opts] Error in FAKE script support
System.TypeInitializationException: The type initializer for '<StartupCode$Fake-Runtime>.$YaafFSharpScripting' threw an exception. --->
System.MissingMethodException: Method not found: 'FSharp.Compiler.SourceCodeServices.FSharpChecker FSharp.Compiler.SourceCodeServices.FSharpChecker.Create(Microsoft.FSharp.Core.FSharpOption`1<Int32>, Microsoft.FSharp.Core.FSharpOption`1<Boolean>, Microsoft.FSharp.Core.FSharpOption`1<Boolean>, Microsoft.FSharp.Core.FSharpOption`1<Resolver>, Microsoft.FSharp.Core.FSharpOption`1<Microsoft.FSharp.Core.FSharpFunc`2<System.Tuple`2<System.String,System.DateTime>,Microsoft.FSharp.Core.FSharpOption`1<System.Tuple`3<System.Object,IntPtr,Int32>>>>, Microsoft.FSharp.Core.FSharpOption`1<Boolean>)'.

We need to update YaafFSharpScripting and then update FSAC to make FAKE Support work again.

@baronfel
Copy link
Contributor Author

cc @matthid do you have time to help here? If not I can maybe take a look this weekend.

@matthid
Copy link
Contributor

matthid commented Feb 27, 2020

I think FakeRuntime uses it's own version of this file so we need to update in fake only. I'll not give any promises at the moment...

@baronfel
Copy link
Contributor Author

Thanks for the clarification! I'll take a stab at it there then.

@Krzysztof-Cieslak
Copy link
Member

I guess this is fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants