From 29d343246082072a99b25e5806f7235ce7cea2a2 Mon Sep 17 00:00:00 2001 From: Sandip Kakadiya Date: Thu, 30 Jul 2020 11:43:01 +0530 Subject: [PATCH] analyze improved & new version released --- CHANGELOG.md | 16 ++++ analysis_options.yaml | 7 +- example/pubspec.lock | 74 +++++++++++++------ lib/components/button/gf_button.dart | 2 +- lib/components/button/gf_social_button.dart | 41 +++++++++++ pubspec.lock | 81 +++++++++++++++++---- pubspec.yaml | 2 +- 7 files changed, 179 insertions(+), 44 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 20676d1a..2e2fe7c1 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -1,5 +1,21 @@ # Changelog +## 1.1.2 - 2020-07-30 + +### Fixed +* [GFAppBar] clear button does not fire onChanged #149 +* [GFCarousel] initialPage Not Honored if Page Indicators Enabled. #144 +* [GFCarousel] timer of the autoPlay is not disposed #143 +* [GFCarousel] active page indicator is not being updated without "onPageChanged" #139 +* [GFTabBar] Docs say about isScrollable which is not supported #132 + +### Update +* couple of compoenents (WIP) + - GFCheckboxTile + - GFRadioTile + + + ## 1.1.1 - 2020-06-26 ### Added diff --git a/analysis_options.yaml b/analysis_options.yaml index 070fe4ce..3c87f40e 100644 --- a/analysis_options.yaml +++ b/analysis_options.yaml @@ -13,7 +13,7 @@ linter: # conflicts with the Flutter convention of putting {Key key} first and {Widget child} last # - always_put_required_named_parameters_first - always_require_non_null_named_parameters - # - annotate_overrides + - annotate_overrides - avoid_annotating_with_dynamic - avoid_as - avoid_bool_literals_in_conditional_expressions @@ -33,7 +33,7 @@ linter: - avoid_relative_lib_imports - avoid_renaming_method_parameters - avoid_return_types_on_setters - # - avoid_returning_null + - avoid_returning_null - avoid_returning_null_for_void - avoid_returning_this - avoid_setters_without_getters @@ -49,6 +49,7 @@ linter: # - cascade_invocations - close_sinks - comment_references + # required for couple of GetWidget pattern # - constant_identifier_names - control_flow_in_finally - curly_braces_in_flow_control_structures @@ -75,7 +76,7 @@ linter: # - omit_local_variable_types - one_member_abstracts - only_throw_errors - # in some places it is required to override fileds + # in some places it is required to override fields # - overridden_fields - package_api_docs - package_names diff --git a/example/pubspec.lock b/example/pubspec.lock index 328323fb..39ab618f 100644 --- a/example/pubspec.lock +++ b/example/pubspec.lock @@ -1,41 +1,48 @@ # Generated by pub # See https://dart.dev/tools/pub/glossary#lockfile packages: + archive: + dependency: transitive + description: + name: archive + url: "https://pub.dartlang.org" + source: hosted + version: "2.0.11" + args: + dependency: transitive + description: + name: args + url: "https://pub.dartlang.org" + source: hosted + version: "1.5.2" async: dependency: transitive description: name: async url: "https://pub.dartlang.org" source: hosted - version: "2.4.1" + version: "2.4.0" boolean_selector: dependency: transitive description: name: boolean_selector url: "https://pub.dartlang.org" source: hosted - version: "2.0.0" + version: "1.0.5" charcode: dependency: transitive description: name: charcode url: "https://pub.dartlang.org" source: hosted - version: "1.1.3" - clock: - dependency: transitive - description: - name: clock - url: "https://pub.dartlang.org" - source: hosted - version: "1.0.1" + version: "1.1.2" collection: dependency: transitive description: name: collection url: "https://pub.dartlang.org" source: hosted - version: "1.14.12" + version: "1.14.11" convert: dependency: transitive description: @@ -43,6 +50,13 @@ packages: url: "https://pub.dartlang.org" source: hosted version: "2.1.1" + crypto: + dependency: transitive + description: + name: crypto + url: "https://pub.dartlang.org" + source: hosted + version: "2.1.3" cupertino_icons: dependency: "direct main" description: @@ -50,13 +64,6 @@ packages: url: "https://pub.dartlang.org" source: hosted version: "0.1.3" - fake_async: - dependency: transitive - description: - name: fake_async - url: "https://pub.dartlang.org" - source: hosted - version: "1.1.0" flutter: dependency: "direct main" description: flutter @@ -85,7 +92,14 @@ packages: path: ".." relative: true source: path - version: "1.1.1" + version: "1.1.2" + image: + dependency: transitive + description: + name: image + url: "https://pub.dartlang.org" + source: hosted + version: "2.1.4" matcher: dependency: transitive description: @@ -106,7 +120,7 @@ packages: name: path url: "https://pub.dartlang.org" source: hosted - version: "1.7.0" + version: "1.6.4" path_drawing: dependency: transitive description: @@ -121,6 +135,13 @@ packages: url: "https://pub.dartlang.org" source: hosted version: "0.1.4" + pedantic: + dependency: transitive + description: + name: pedantic + url: "https://pub.dartlang.org" + source: hosted + version: "1.8.0+1" petitparser: dependency: transitive description: @@ -135,6 +156,13 @@ packages: url: "https://pub.dartlang.org" source: hosted version: "1.0.1" + quiver: + dependency: transitive + description: + name: quiver + url: "https://pub.dartlang.org" + source: hosted + version: "2.0.5" sky_engine: dependency: transitive description: flutter @@ -146,7 +174,7 @@ packages: name: source_span url: "https://pub.dartlang.org" source: hosted - version: "1.7.0" + version: "1.5.5" stack_trace: dependency: transitive description: @@ -181,7 +209,7 @@ packages: name: test_api url: "https://pub.dartlang.org" source: hosted - version: "0.2.15" + version: "0.2.11" typed_data: dependency: transitive description: @@ -232,5 +260,5 @@ packages: source: hosted version: "3.5.0" sdks: - dart: ">=2.6.0 <3.0.0" + dart: ">=2.4.0 <3.0.0" flutter: ">=1.12.8 <2.0.0" diff --git a/lib/components/button/gf_button.dart b/lib/components/button/gf_button.dart index 7a986ef6..80501483 100644 --- a/lib/components/button/gf_button.dart +++ b/lib/components/button/gf_button.dart @@ -1019,7 +1019,7 @@ class _GFButtonState extends State { } else if (widget.fullWidthButton == true) { return MediaQuery.of(context).size.width; } else { - return null; + return MediaQuery.of(context).size.width * 0.88; } } diff --git a/lib/components/button/gf_social_button.dart b/lib/components/button/gf_social_button.dart index fe077f9d..54249394 100644 --- a/lib/components/button/gf_social_button.dart +++ b/lib/components/button/gf_social_button.dart @@ -65,84 +65,111 @@ class GFSocialButton extends GFButton { ); /// Called when the button is tapped or otherwise activated. + @override final VoidCallback onPressed; /// Called by the underlying [InkWell] widget's InkWell.onHighlightChanged callback. + @override final ValueChanged onHighlightChanged; /// Defines the default text style, with [Material.textStyle], for the button's [child]. + @override final TextStyle textStyle; /// The border side for the button's [Material]. + @override final BorderSide borderSide; /// The box shadow for the button's [Material], if GFButtonType is solid + @override final BoxShadow boxShadow; /// Pass [GFColors] or [Color]. The color for the button's [Material] when it has the input focus. + @override final Color focusColor; /// Pass [GFColors] or [Color]. The color for the button's [Material] when a pointer is hovering over it. + @override final Color hoverColor; /// Pass [GFColors] or [Color]. The highlight color for the button's [InkWell]. + @override final Color highlightColor; /// Pass [GFColors] or [Color]. The splash color for the button's [InkWell]. + @override final Color splashColor; /// The elevation for the button's [Material] when the button is [enabled] but not pressed. + @override final double elevation; /// The elevation for the button's [Material] when the button is [enabled] and a pointer is hovering over it. + @override final double hoverElevation; /// The elevation for the button's [Material] when the button is [enabled] and has the input focus. + @override final double focusElevation; /// The elevation for the button's [Material] when the button is [enabled] and pressed. + @override final double highlightElevation; /// The elevation for the button's [Material] when the button is not [enabled]. + @override final double disabledElevation; /// The internal padding for the button's [child]. + @override final EdgeInsetsGeometry padding; /// Defines the button's size. + @override final BoxConstraints constraints; /// The shape of the button's [Material]. + @override final ShapeBorder borderShape; /// Defines the duration of animated changes for [shape] and [elevation]. + @override final Duration animationDuration; /// Typically the button's label. + @override final Widget child; /// Whether the button is enabled or disabled. + @override bool get enabled => onPressed != null; /// Configures the minimum size of the tap target. + @override final MaterialTapTargetSize materialTapTargetSize; /// {@macro flutter.widgets.Focus.focusNode} + @override final FocusNode focusNode; /// {@macro flutter.widgets.Focus.autofocus} + @override final bool autofocus; /// {@macro flutter.widgets.Clip} + @override final Clip clipBehavior; /// Button type of [GFButtonType] i.e, solid, outline, outline2x, transparent + @override final GFButtonType type; /// Button type of GFSocialButtonShape i.e, standard, pills, square, shadow, icons + @override final GFButtonShape shape; /// Pass [GFColors] or [Color] + @override final Color color; /// The fill color of the button when the button is disabled. @@ -153,9 +180,12 @@ class GFSocialButton extends GFButton { /// See also: /// /// * [color] - the fill color of the button when the button is [enabled]. + + @override final Color disabledColor; /// Pass [GFColors] or [Color] + @override final Color textColor; /// The color to use for this button's text when the button is disabled. @@ -172,27 +202,35 @@ class GFSocialButton extends GFButton { /// See also: /// /// * [textColor] - The color to use for this button's text when the button is [enabled]. + @override final Color disabledTextColor; /// size of [double] or [GFSize] i.e, 1.2, small, medium, large etc. + @override final double size; /// text of type [String] is alternative to child. text will get priority over child + @override final String text; /// icon of type [Widget] + @override final Widget icon; /// icon type of [GFPosition] i.e, start, end + @override final GFPosition position; /// on true state blockButton gives block size button + @override final bool blockButton; /// on true state full width Button gives full width button + @override final bool fullWidthButton; /// on true state default box shadow appears around button, if GFButtonType is solid + @override final bool buttonBoxShadow; /// A set of thirteen colors that can be used to derive the button theme's @@ -205,6 +243,7 @@ class GFSocialButton extends GFButton { /// The colors for new button classes can be defined exclusively in terms /// of [colorScheme]. When it's possible, the existing buttons will /// (continue to) gradually migrate to it. + @override final ColorScheme colorScheme; /// Whether detected gestures should provide acoustic and/or haptic feedback. @@ -215,6 +254,7 @@ class GFSocialButton extends GFButton { /// See also: /// /// * [Feedback] for providing platform-specific feedback to certain actions. + @override final bool enableFeedback; /// Called when the button is long-pressed. @@ -224,6 +264,7 @@ class GFSocialButton extends GFButton { /// See also: /// /// * [enabled], which is true if the button is enabled. + @override final VoidCallback onLongPress; Widget build(BuildContext context) => GFButton( diff --git a/pubspec.lock b/pubspec.lock index 4211cac5..67a7df16 100644 --- a/pubspec.lock +++ b/pubspec.lock @@ -1,48 +1,62 @@ # Generated by pub # See https://dart.dev/tools/pub/glossary#lockfile packages: + archive: + dependency: transitive + description: + name: archive + url: "https://pub.dartlang.org" + source: hosted + version: "2.0.11" + args: + dependency: transitive + description: + name: args + url: "https://pub.dartlang.org" + source: hosted + version: "1.5.2" async: dependency: transitive description: name: async url: "https://pub.dartlang.org" source: hosted - version: "2.4.1" + version: "2.4.0" boolean_selector: dependency: transitive description: name: boolean_selector url: "https://pub.dartlang.org" source: hosted - version: "2.0.0" + version: "1.0.5" charcode: dependency: transitive description: name: charcode url: "https://pub.dartlang.org" source: hosted - version: "1.1.3" - clock: + version: "1.1.2" + collection: dependency: transitive description: - name: clock + name: collection url: "https://pub.dartlang.org" source: hosted - version: "1.0.1" - collection: + version: "1.14.11" + convert: dependency: transitive description: - name: collection + name: convert url: "https://pub.dartlang.org" source: hosted - version: "1.14.12" - fake_async: + version: "2.1.1" + crypto: dependency: transitive description: - name: fake_async + name: crypto url: "https://pub.dartlang.org" source: hosted - version: "1.1.0" + version: "2.1.3" flutter: dependency: "direct main" description: flutter @@ -53,6 +67,13 @@ packages: description: flutter source: sdk version: "0.0.0" + image: + dependency: transitive + description: + name: image + url: "https://pub.dartlang.org" + source: hosted + version: "2.1.4" matcher: dependency: transitive description: @@ -73,7 +94,28 @@ packages: name: path url: "https://pub.dartlang.org" source: hosted - version: "1.7.0" + version: "1.6.4" + pedantic: + dependency: transitive + description: + name: pedantic + url: "https://pub.dartlang.org" + source: hosted + version: "1.8.0+1" + petitparser: + dependency: transitive + description: + name: petitparser + url: "https://pub.dartlang.org" + source: hosted + version: "2.4.0" + quiver: + dependency: transitive + description: + name: quiver + url: "https://pub.dartlang.org" + source: hosted + version: "2.0.5" sky_engine: dependency: transitive description: flutter @@ -85,7 +127,7 @@ packages: name: source_span url: "https://pub.dartlang.org" source: hosted - version: "1.7.0" + version: "1.5.5" stack_trace: dependency: transitive description: @@ -120,7 +162,7 @@ packages: name: test_api url: "https://pub.dartlang.org" source: hosted - version: "0.2.15" + version: "0.2.11" typed_data: dependency: transitive description: @@ -135,5 +177,12 @@ packages: url: "https://pub.dartlang.org" source: hosted version: "2.0.8" + xml: + dependency: transitive + description: + name: xml + url: "https://pub.dartlang.org" + source: hosted + version: "3.5.0" sdks: - dart: ">=2.6.0 <3.0.0" + dart: ">=2.4.0 <3.0.0" diff --git a/pubspec.yaml b/pubspec.yaml index 8c778268..76d0f85e 100644 --- a/pubspec.yaml +++ b/pubspec.yaml @@ -1,6 +1,6 @@ name: getwidget description: GetWidget is open source libraries that come with pre-build 1000+ UI components. It makes development faster & more enjoyable. You can customize the component as per your need. -version: 1.1.1 +version: 1.1.2 homepage: https://github.com/ionicfirebaseapp/getwidget environment: