Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

do not bundle 3rd party imports with the components #347

Closed
1 of 3 tasks
rolandjitsu opened this issue Dec 5, 2017 · 2 comments
Closed
1 of 3 tasks

do not bundle 3rd party imports with the components #347

rolandjitsu opened this issue Dec 5, 2017 · 2 comments

Comments

@rolandjitsu
Copy link

Stencil version:

I'm submitting a:

Current behavior:

Currently, any 3rd party imports inside the components will be bundled with the dist for the component.
In some cases we may not want to do this. A good example is rxjs, which is relatively large. And in my specific case, where I use the components I already import rxjs.

Expected behavior:

There should be a way to not bundle 3rd party imports with the components. With rollup this can be done by using a combination of globals and external:

module.exports = {
    globals: {
        'rxjs/Observable': 'Rx'
    },
    external: [
        'rxjs/Observable'
    ]
}

Steps to reproduce:

Related code:

// insert any relevant code here

Other information:

@adamdbradley
Copy link
Contributor

Closing this as a dup of #162 Thanks

@rolandjitsu
Copy link
Author

@adamdbradley true, I missed that issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants