Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Ionic v4] ion-header ion-toolbar height to big on iPhone 6s #15073

Closed
peterpeterparker opened this issue Aug 6, 2018 · 4 comments
Closed

[Ionic v4] ion-header ion-toolbar height to big on iPhone 6s #15073

peterpeterparker opened this issue Aug 6, 2018 · 4 comments
Assignees

Comments

@peterpeterparker
Copy link
Contributor

peterpeterparker commented Aug 6, 2018

Ionic Info
@ionic/angular: "4.0.0-beta.1"

Describe the Bug
The ion-header ion-toolbar height is too big on iPhone 6s / iOS 11.4

As you could see in the enclosed screenshot, the height is bigger than 44px

Source of the problem is the fact that --ion-statusbar-padding is set to 20px; (see
https://github.com/ionic-team/ionic/blob/fd8f875a5f9bf4435f214b77a703ca8efce12501/core/src/components/app/app.ios.scss)

I didn't tried Android but I guess same problem since the padding is also set to 20px; (
https://github.com/ionic-team/ionic/blob/fd8f875a5f9bf4435f214b77a703ca8efce12501/core/src/components/app/app.md.scss)

Expected Behavior
A correct header size on devices

Code

<ion-header>
  <ion-toolbar>
    <ion-title>SOMETHING</ion-title>
  </ion-toolbar>
</ion-header>

Screenshot

image-1

@ionitron-bot ionitron-bot bot added triage and removed triage labels Aug 6, 2018
@pvskasyrskiy
Copy link

I have the same issue at android

@manucorporat manucorporat self-assigned this Aug 7, 2018
@peterpeterparker
Copy link
Contributor Author

All good with v4.0.0-beta2, thx a lot 👍

@doender
Copy link

doender commented Aug 30, 2018

I have encountered this issue again in 4.0.0-beta.6 due to this CSS rule:

ion-header ion-toolbar:first-child {
   padding-top: var(--ion-safe-area-top,0);
}

@ionitron-bot
Copy link

ionitron-bot bot commented Sep 29, 2018

Thanks for the issue! This issue is being locked to prevent comments that are not relevant to the original issue. If this is still an issue with the latest version of Ionic, please create a new issue and ensure the template is fully filled out.

@ionitron-bot ionitron-bot bot locked and limited conversation to collaborators Sep 29, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants