Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ion-range knobs can be moved from the bar using arrow keys and ionchange not fired using arraow keys to update the ion-range values #15065

Closed
amsdams opened this issue Aug 6, 2018 · 2 comments
Assignees

Comments

@amsdams
Copy link

amsdams commented Aug 6, 2018

Ionic version: (check one with "x")
(For Ionic 1.x issues, please use https://github.com/ionic-team/ionic-v1)
[ ] 2.x
[ ] 3.x
[ x] 4.x
[x] 4.0.0-beta.1

I'm submitting a ... (check one with "x")
[x ] bug report
[ ] feature request

Current behavior:

it is possible to move the knobs in ion-outside of the bar and container using arrow keys.
ionchange event not fired when using arrow keys to move the knobs

Expected behavior:

it is not possible to move the knobs in ion-outside of the bar and container using arrow keys.
ionchange event is fired when using arrow keys to move the knobs.

Steps to reproduce:

Related code:

<script src="https://unpkg.com/@ionic/[email protected]/dist/ionic.js"></script>
<ion-item>
  <ion-range min="-200" max="200" color="secondary">
    <ion-label slot="start">-200</ion-label>
    <ion-label slot="end">200</ion-label>
  </ion-range>
</ion-item>

Other information:

Ionic info: (run ionic info from a terminal/cmd prompt and paste output below):

Ionic:

   ionic (Ionic CLI) : 4.0.3

System:

   NodeJS : v10.7.0
   npm    : 6.2.0
   OS     : macOS High Sierra

PS: not using ionic cli. just using stencil starter with ionic core dep for using ion-range

@ionitron-bot ionitron-bot bot added the triage label Aug 6, 2018
@manucorporat manucorporat self-assigned this Aug 7, 2018
@ionitron-bot ionitron-bot bot removed the triage label Aug 7, 2018
@amsdams
Copy link
Author

amsdams commented Aug 7, 2018

@manucorporat, thank you for helping solving this issue. Are dual knobs still working with this fix?

@ionitron-bot
Copy link

ionitron-bot bot commented Sep 9, 2018

Thanks for the issue! This issue is being locked to prevent comments that are not relevant to the original issue. If this is still an issue with the latest version of Ionic, please create a new issue and ensure the template is fully filled out.

@ionitron-bot ionitron-bot bot locked and limited conversation to collaborators Sep 9, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants