Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug with light segment in primary toolbar #14854

Closed
brandyscarney opened this issue Jul 24, 2018 · 6 comments
Closed

Bug with light segment in primary toolbar #14854

brandyscarney opened this issue Jul 24, 2018 · 6 comments
Assignees

Comments

@brandyscarney
Copy link
Member

Bug Report

There is an issue with the active segment button color where it is black on a light segment in a primary toolbar:

<ion-toolbar color="primary">
  <ion-segment color="light">
    <ion-segment-button value="sunny">
      Sunny
    </ion-segment-button>
    <ion-segment-button value="rainy" checked>
      Rainy
    </ion-segment-button>
  </ion-segment>
</ion-toolbar>

localhost_3333_src_components_segment_test_basic iphone 6_7_8

@ionitron-bot ionitron-bot bot added triage and removed triage labels Jul 24, 2018
@camwiegert camwiegert self-assigned this Aug 14, 2018
@dtaalbers
Copy link

I think I am having the same issue with the searchbar.

At first glance its fine. This is the route Tabs > Browse

screen shot 2018-08-16 at 11 13 20

When I navigate to Tabs > Browse > Categories and then back to Tabs > Browse it shows like this

screen shot 2018-08-16 at 11 12 45

Btw the searchbar on the Categories page is also black after nagivating Tabs > Browse > Categories. It has the same HTML as the Browse page. See below

My header on the Browse and Categories pages.

<ion-header>
    <ion-toolbar color="primary" no-border-bottom>
        <ion-title>Bladeren</ion-title>
        <ion-buttons slot="right">
            <ion-spinner class="spinner" *ngIf="is_loading"></ion-spinner>
        </ion-buttons>
    </ion-toolbar>
    <ion-searchbar [(ngModel)]="q" [showCancelButton]="true" (ionChange)="search()" (ionClear)="cancel_search()" (ionCancel)="cancel_search()" debounce="850" placeholder="Zoek naar een product" cancelButtonText="Annuleren" animated="true">
    </ion-searchbar>
</ion-header>

I navigate with this:

this.nav_controller.goForward(`/tabs/(browse:categories)?id=${group.id}&parent='Bladeren'`);

Not sure if my issue is related to this one, but it seems so. If it is not related should I create a separate issue for this?

@dtaalbers
Copy link

dtaalbers commented Aug 16, 2018

Work around:

ion-header {
  background: var(--ion-color-white) !important;

  ion-searchbar {
      --background: var(--ion-color-light-gray);
  }
}

Variables:
  --ion-color-white: #fff;
  --ion-color-light-gray: #ededed;

@brandyscarney
Copy link
Member Author

@dtaalbers I think this might be related to this: #15121

I believe @manucorporat is working on a fix for that.

@camwiegert
Copy link
Contributor

@brandyscarney I think this is actually related to how we're applying the toolbar colors to segment children without a color attribute. I have a fix I'll push shortly.

@brandyscarney
Copy link
Member Author

@camwiegert Sorry, I was specifically talking about his issue with the black background on toolbars. I don't think that one is related to this issue, and the issue I linked to is what Manu is working on. 🙂

@ionitron-bot
Copy link

ionitron-bot bot commented Sep 16, 2018

Thanks for the issue! This issue is being locked to prevent comments that are not relevant to the original issue. If this is still an issue with the latest version of Ionic, please create a new issue and ensure the template is fully filled out.

@ionitron-bot ionitron-bot bot locked and limited conversation to collaborators Sep 16, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants