Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Testing Ionic 4 - Primary color for tabs not respected in 4.0.0.alpha-9 #14758

Closed
ionitron-bot bot opened this issue Jul 12, 2018 · 3 comments
Closed

Testing Ionic 4 - Primary color for tabs not respected in 4.0.0.alpha-9 #14758

ionitron-bot bot opened this issue Jul 12, 2018 · 3 comments
Assignees
Labels

Comments

@ionitron-bot
Copy link

ionitron-bot bot commented Jul 12, 2018

Description:
Possible regression or I missed something in the updating.
capture342
capture343

Steps to Reproduce:
Repo: peterennis/aetabs@a1be296
Working example from 4.0.0.alpha-6: https://aetabs.adaept.com/tabs/(home:home)

Output:

My ionic info:

C:\ae\adaept.com\aetabs>ionic info

Ionic:

   ionic (Ionic CLI)          : 4.0.0-rc.11 (C:\Users\peter\AppData\Roaming\npm\node_modules\ionic)
   Ionic Framework            : @ionic/angular 4.0.0-alpha.10
   @angular-devkit/core       : 0.7.0-rc.1
   @angular-devkit/schematics : 0.7.0-rc.1
   @angular/cli               : 6.0.8
   @ionic/ng-toolkit          : 1.0.0-rc.10
   @ionic/schematics-angular  : 1.0.0-rc.10

System:

   NodeJS : v8.11.1 (C:\Program Files\nodejs\node.exe)
   npm    : 6.1.0
   OS     : Windows 10


C:\ae\adaept.com\aetabs>

Other Information:

@ghost
Copy link

ghost commented Jul 12, 2018

Android
image
iOS
image

Possibility to apply manually?

  --ion-tabbar-background-color: var(--ion-color-primary);
  --ion-tabbar-text-color: var(--ion-color-light);
  --ion-tabbar-text-color-active: var(--ion-color-light);

@crebuh
Copy link

crebuh commented Aug 30, 2018

I'm still having the same issue with (using beta 6 right now). Is there any workaround. I'm using

--ion-tabbar-text-color-active: var(--ion-color-dark);

which works perfectly for android, but not for iOS.

@ionitron-bot
Copy link
Author

ionitron-bot bot commented Sep 29, 2018

Thanks for the issue! This issue is being locked to prevent comments that are not relevant to the original issue. If this is still an issue with the latest version of Ionic, please create a new issue and ensure the template is fully filled out.

@ionitron-bot ionitron-bot bot locked and limited conversation to collaborators Sep 29, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

2 participants