-
Notifications
You must be signed in to change notification settings - Fork 13.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ionic v4: Tabs - tabbarLayout options are not shown as expected #14611
Comments
4.0.0-alpha.9 Same issue, tabbarLayout seems to have no effect whatever the value as per comment in tabs.d.ts Cannot make https://blog.ionicframework.com/tips-tricks-for-ionic-on-desktop/ On the other side, tabbarPlacement is working as expected, top is working and bottom as well |
Thanks for the issue! Confirmed this is an issue in latest. |
Note to team: I started on this issue but I need to discuss the implementation with @manucorporat |
Thank you @brandyscarney! |
@Mobiletainment I haven't gotten back to finishing it yet. I submitted a PR for it so you can see where it's at: #15113 I have fixed the layout itself but there are still some issues with padding and margin between elements. |
- gets the `tabbarLayout` property working - update badge position based on tabs layout - fix the transforms for icon/text and icon size fixes #14611
This has been fixed and will be in the |
Bug Report
Ionic Info
Run
ionic info
from a terminal/cmd prompt and paste the output below.Describe the Bug
When using
<ion-tabs tabbarLayout="icon-start">
, the tab button icons are still shown on top of the labels:icon-start:
Other options like
icon-end
,icon-bottom
,icon-hide
andtitle-hide
also have layout problems.title-hide:
Steps to Reproduce
Steps to reproduce the behavior:
@ionic/[email protected]
project with the CLI, select the tabs starter:ionic start tabs-layout tabs --type angular
src/app/pages/tabs/tabs.page.html
tabbarLayout="icon-start"
to the<ion-tabs>
npm run start
Related Code
Expected Behavior
Tab button icons should be placed at the side of their labels. Other layout options should be positioned correctly.
Additional Context
List any other information that is relevant to your issue. Stack traces, related issues, suggestions on how to fix, Stack Overflow links, forum links, screenshots, OS if applicable, etc.
The text was updated successfully, but these errors were encountered: