Skip to content

Commit

Permalink
fix(button): add box-sizing so anchor buttons won't exceed max-width
Browse files Browse the repository at this point in the history
fixes #14760
  • Loading branch information
brandyscarney committed Jul 12, 2018
1 parent 8e58ea4 commit 9c9f081
Show file tree
Hide file tree
Showing 2 changed files with 10 additions and 0 deletions.
1 change: 1 addition & 0 deletions core/src/components/button/button.scss
Original file line number Diff line number Diff line change
Expand Up @@ -106,6 +106,7 @@
z-index: 0;
display: inline-block;
overflow: hidden;
box-sizing: border-box;

height: var(--height);

Expand Down
9 changes: 9 additions & 0 deletions core/src/components/button/test/expand/index.html
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,14 @@
<ion-button expand="block">Block</ion-button>
<ion-button expand="full">Full</ion-button>
</p>
<p>
<ion-button expand="block">Button Block</ion-button>
<ion-button expand="block" href="#">Anchor Block</ion-button>
</p>
<p>
<ion-button expand="full">Button Full</ion-button>
<ion-button expand="full" href="#">Anchor Full</ion-button>
</p>
<p>
<ion-button expand="block" color="dark" fill="outline">Block + Outline</ion-button>
<ion-button expand="full" color="dark" fill="outline">Full + Outline</ion-button>
Expand All @@ -43,6 +51,7 @@
<ion-button expand="block" shape="round">Block + Round</ion-button>
<ion-button expand="full" shape="round">Full + Round</ion-button>
</p>

</ion-content>

</ion-app>
Expand Down

0 comments on commit 9c9f081

Please sign in to comment.