fix(overlay): overlay is not hidden

ionic-team · Aug 29, 2018 · 89ba55d · 89ba55d
1 parent 2268346
commit 89ba55d
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 5 deletions.
diff --git a/core/src/components/datetime/datetime.tsx b/core/src/components/datetime/datetime.tsx
@@ -232,9 +232,7 @@ export class Datetime {
     const pickerOptions = this.generatePickerOptions();
     this.picker = await this.pickerCtrl.create(pickerOptions);
     await this.validate();
-    if (this.picker) {
-      await this.picker.present();
-    }
+    await this.picker.present();
   }
 
   private emitStyle() {

diff --git a/core/src/utils/overlays.ts b/core/src/utils/overlays.ts
@@ -9,7 +9,7 @@ export function createOverlay<T extends HTMLIonOverlayElement>(element: T, opts:
   // convert the passed in overlay options into props
   // that get passed down into the new overlay
   Object.assign(element, opts);
-  element.classList.add('ion-page-hidden');
+  element.classList.add('ion-page-invisible');
   const overlayIndex = lastId++;
   element.overlayIndex = overlayIndex;
   if (!element.hasAttribute('id')) {
@@ -137,7 +137,7 @@ async function overlayAnimation(
   }
 
   // Make overlay visible in case it's hidden
-  baseEl.classList.remove('ion-page-hidden');
+  baseEl.classList.remove('ion-page-invisible');
 
   const aniRoot = baseEl.shadowRoot || overlay.el;
   const animation = overlay.animation = await overlay.animationCtrl.create(animationBuilder, aniRoot, opts);