From 565a499f0c86231d84b12cf0ade99c018f2bc645 Mon Sep 17 00:00:00 2001 From: Liam DeBeasi Date: Thu, 29 Feb 2024 17:16:34 -0500 Subject: [PATCH 1/5] fix(input-shims): disable input blurring util by default --- core/src/utils/input-shims/input-shims.ts | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/core/src/utils/input-shims/input-shims.ts b/core/src/utils/input-shims/input-shims.ts index 5919a5fa1b2..77511f9876a 100644 --- a/core/src/utils/input-shims/input-shims.ts +++ b/core/src/utils/input-shims/input-shims.ts @@ -33,7 +33,14 @@ export const startInputShims = async (config: Config, platform: 'ios' | 'android const keyboardHeight = config.getNumber('keyboardHeight', 290); const scrollAssist = config.getBoolean('scrollAssist', true); const hideCaret = config.getBoolean('hideCaretOnScroll', isIOS); - const inputBlurring = config.getBoolean('inputBlurring', isIOS); + + /** + * The team is evaluating if inputBlurring is still needed. As a result + * this feature is disabled by default as of Ionic 8.0. Developers are + * able to re-enabled it temporarily. The team may remove this utility + * if it is determined that doing so would not bring any adverse side effects. + */ + const inputBlurring = config.getBoolean('inputBlurring', false); const scrollPadding = config.getBoolean('scrollPadding', true); const inputs = Array.from(doc.querySelectorAll('ion-input, ion-textarea')) as HTMLElement[]; From 37d1b418c06a038b42dec170b97e24016398e334 Mon Sep 17 00:00:00 2001 From: Liam DeBeasi Date: Thu, 29 Feb 2024 17:33:17 -0500 Subject: [PATCH 2/5] add tech debt ticket --- core/src/utils/input-shims/input-shims.ts | 2 ++ 1 file changed, 2 insertions(+) diff --git a/core/src/utils/input-shims/input-shims.ts b/core/src/utils/input-shims/input-shims.ts index 77511f9876a..9ece278b597 100644 --- a/core/src/utils/input-shims/input-shims.ts +++ b/core/src/utils/input-shims/input-shims.ts @@ -39,6 +39,7 @@ export const startInputShims = async (config: Config, platform: 'ios' | 'android * this feature is disabled by default as of Ionic 8.0. Developers are * able to re-enabled it temporarily. The team may remove this utility * if it is determined that doing so would not bring any adverse side effects. + * TODO FW-6014 remove input blurring utility (including implementation) */ const inputBlurring = config.getBoolean('inputBlurring', false); const scrollPadding = config.getBoolean('scrollPadding', true); @@ -120,6 +121,7 @@ export const startInputShims = async (config: Config, platform: 'ios' | 'android } }; +console.log(inputBlurring, INPUT_BLURRING) if (inputBlurring && INPUT_BLURRING) { enableInputBlurring(); } From 85fc6f82150a786f3285751f186beaf1a5cbc247 Mon Sep 17 00:00:00 2001 From: Liam DeBeasi Date: Thu, 29 Feb 2024 17:40:27 -0500 Subject: [PATCH 3/5] chore: lint --- core/src/utils/input-shims/input-shims.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/core/src/utils/input-shims/input-shims.ts b/core/src/utils/input-shims/input-shims.ts index 9ece278b597..efd3ed160e5 100644 --- a/core/src/utils/input-shims/input-shims.ts +++ b/core/src/utils/input-shims/input-shims.ts @@ -121,7 +121,7 @@ export const startInputShims = async (config: Config, platform: 'ios' | 'android } }; -console.log(inputBlurring, INPUT_BLURRING) + console.log(inputBlurring, INPUT_BLURRING); if (inputBlurring && INPUT_BLURRING) { enableInputBlurring(); } From 4702b5d752af07b34300ce9177b0360236f26b3f Mon Sep 17 00:00:00 2001 From: Liam DeBeasi Date: Fri, 1 Mar 2024 10:45:59 -0500 Subject: [PATCH 4/5] Update core/src/utils/input-shims/input-shims.ts Co-authored-by: Amanda Johnston <90629384+amandaejohnston@users.noreply.github.com> --- core/src/utils/input-shims/input-shims.ts | 1 - 1 file changed, 1 deletion(-) diff --git a/core/src/utils/input-shims/input-shims.ts b/core/src/utils/input-shims/input-shims.ts index efd3ed160e5..bf8d6944189 100644 --- a/core/src/utils/input-shims/input-shims.ts +++ b/core/src/utils/input-shims/input-shims.ts @@ -121,7 +121,6 @@ export const startInputShims = async (config: Config, platform: 'ios' | 'android } }; - console.log(inputBlurring, INPUT_BLURRING); if (inputBlurring && INPUT_BLURRING) { enableInputBlurring(); } From bd2c01c4f4c786fe1b5be17d03139e81a4b884e7 Mon Sep 17 00:00:00 2001 From: Liam DeBeasi Date: Fri, 1 Mar 2024 10:46:03 -0500 Subject: [PATCH 5/5] Update core/src/utils/input-shims/input-shims.ts Co-authored-by: Amanda Johnston <90629384+amandaejohnston@users.noreply.github.com> --- core/src/utils/input-shims/input-shims.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/core/src/utils/input-shims/input-shims.ts b/core/src/utils/input-shims/input-shims.ts index bf8d6944189..879fbfff870 100644 --- a/core/src/utils/input-shims/input-shims.ts +++ b/core/src/utils/input-shims/input-shims.ts @@ -37,7 +37,7 @@ export const startInputShims = async (config: Config, platform: 'ios' | 'android /** * The team is evaluating if inputBlurring is still needed. As a result * this feature is disabled by default as of Ionic 8.0. Developers are - * able to re-enabled it temporarily. The team may remove this utility + * able to re-enable it temporarily. The team may remove this utility * if it is determined that doing so would not bring any adverse side effects. * TODO FW-6014 remove input blurring utility (including implementation) */