Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

_variables.scss hardcoded colors #731

Closed
dbercht opened this issue Mar 5, 2014 · 3 comments
Closed

_variables.scss hardcoded colors #731

dbercht opened this issue Mar 5, 2014 · 3 comments
Assignees
@adamdbradley
Milestone
1.0.0-beta.1

Comments

@dbercht
Copy link

dbercht commented Mar 5, 2014

Trying to customize ionic CSS but there are a few hardcoded HEX colors, which seems like they should be modified to variables, namely:
$toggle-on-bg-color
$checkbox-off-border-color
$checkbox-on-bg-color
$checkbox-on-border-color

They have a hardcoded value of #4a87ee, shouldn't it be $positive instead?
@adamdbradley
Copy link
Contributor

100% correct, thanks for pointing that out.

@adamdbradley adamdbradley added this to the 1.0 Beta milestone Mar 5, 2014
@adamdbradley adamdbradley self-assigned this Mar 5, 2014
@dbercht
Copy link
Author

dbercht commented Mar 5, 2014

Thank you!

@ionitron-bot
Copy link

ionitron-bot bot commented Sep 6, 2018

Thanks for the issue! This issue is being locked to prevent comments that are not relevant to the original issue. If this is still an issue with the latest version of Ionic, please create a new issue and ensure the template is fully filled out.

@ionitron-bot ionitron-bot bot locked and limited conversation to collaborators Sep 6, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@adamdbradley adamdbradley

Labels
None yet
Projects
None yet
Milestone
1.0.0-beta.1
Development

No branches or pull requests
2 participants
@dbercht @adamdbradley