Skip to content

Footer not shown when combinated with ion-tabs #728

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ck-ws opened this issue Mar 5, 2014 · 5 comments
Closed

Footer not shown when combinated with ion-tabs #728

ck-ws opened this issue Mar 5, 2014 · 5 comments
Assignees
Milestone

Comments

@ck-ws
Copy link

ck-ws commented Mar 5, 2014

Steps to follow:

  1. Create a tabbed app
  2. Create a tab with ion-content
  3. add has-footer="true" and has-tabs="true" to ion-content
  4. add a footer below the ion-content with footer component (http://ionicframework.com/docs/components/#footer)

Problem:
Footer won't show because it is hidden behind the tab bar.

Possible Solution:

  • add has-tabs as class to footer
  • add new CSS:
.has-footer.has-tabs {
  bottom: 93px;
}
  • change CSS:
    .has-tabs -> .has-tabs, .bar-footer.has-tabs or change order of source (currently bottom get's overwritten without this change)

CodePen demo (incl. fix):
http://codepen.io/anon/pen/pijke

@mhartington
Copy link
Contributor

Is this what you're hoping to achieve?

http://codepen.io/mhartington/pen/pumtb

@ck-ws
Copy link
Author

ck-ws commented Mar 7, 2014

Yep. Just added an issue so that this (possibly) could be the default in the future.
As can see, I already added the needed CSS in the Codepen (but commented it out).

@adamdbradley adamdbradley added this to the 1.0 Beta milestone Mar 10, 2014
@adamdbradley adamdbradley self-assigned this Mar 10, 2014
@gereko3d
Copy link

It looks like this issue is still open, in some circumstances.
I noticed that, under iOS (no problems with Android) the directive keyboard-attach doesn't work inside a footer, when, in my layout, I also have a tab-bar. The proposed fix makes the footer and the tab bar appear, but when I focus an input inside the footer, the keyboard is shown, but it covers both the footer and the tab-bar.
Under Android both the footer and the input are pushed up (it would be better if it would be the footer only, but it is not such a big problem).
Any idea about that?

@simran66
Copy link

simran66 commented Dec 6, 2015

I faced the same problem sometime back and here is the fix that worked for me:
http://www.yourtechchick.com/angularjs/ionic/how-to-use-a-footer-with-ion-tabs-in-ionic/

Hope that helps.

@omid-keihani
Copy link

you made by ion view , how can make sub footer with ion tabs ???

@ionitron-bot ionitron-bot bot locked and limited conversation to collaborators Sep 8, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants