Skip to content

Flashing when close right sidebar menu #556

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
adamdbradley opened this issue Feb 7, 2014 · 6 comments
Closed

Flashing when close right sidebar menu #556

adamdbradley opened this issue Feb 7, 2014 · 6 comments
Assignees
Milestone

Comments

@adamdbradley
Copy link
Contributor

I'm trying to add action menu on the right side. It was flashing left menu in right menu when I toggle or swipe to close right side bar.

http://forum.ionicframework.com/t/flashing-when-close-right-sidebar-menu-issue/902

@adamdbradley adamdbradley self-assigned this Feb 7, 2014
@adamdbradley adamdbradley modified the milestones: 1.0 Beta, 0.9.25, 0.9.26 Feb 10, 2014
@codegrean
Copy link

I ran emulator with Android 4.3. Also happen in browser.

@zonason
Copy link

zonason commented Feb 13, 2014

So, it appears that the left side flickers briefly, likely because the animation jerks. Commenting out the left side reduces the impact of the flicker or it goes away, not certain, speeds are a little too fast to discern. A hack might be to make the left side visibility default to hidden and only when open amount > 0, change visibility. part of this can be handled on the toggleLeft() function in ionic.js.

@ajoslin
Copy link
Contributor

ajoslin commented Feb 13, 2014

Might be better to even make the menus be display: none while closed (for perf as well)

@zonason
Copy link

zonason commented Feb 13, 2014

modifying ionic.js is outside the purview of angular, how would you go about adding a watch or something similar, but performant, to change display none/block for drag events in the SideMenuController?

@zonason
Copy link

zonason commented Feb 13, 2014

NM Andy, I've got it. It's relatively simple, modify the openAmount function on ionic.js for open and close... still, this is a hack, hopefully folks can find a proper solution.

@ionitron-bot
Copy link

ionitron-bot bot commented Sep 6, 2018

Thanks for the issue! This issue is being locked to prevent comments that are not relevant to the original issue. If this is still an issue with the latest version of Ionic, please create a new issue and ensure the template is fully filled out.

@ionitron-bot ionitron-bot bot locked and limited conversation to collaborators Sep 6, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants