Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tabs, tab-bar): use standalone tab bar in Vue, React #29940

Merged
merged 3 commits into from
Oct 16, 2024

Conversation

thetaPC
Copy link
Contributor

@thetaPC thetaPC commented Oct 15, 2024

Issue number: resolves #29885, resolves #29924


What is the current behavior?

React and Vue:

Tab bar could be a standalone element within IonTabs and would navigate without issues with a router outlet before v8.3:

<IonTabs>
  <IonRouterOutlet></IonRouterOutlet>

  <IonTabBar></IonTabBar>
</IonTabs>

It would work as if it was written as:

<IonTabs>
  <IonRouterOutlet></IonRouterOutlet>

  <IonTabBar slot="bottom">
    <!-- Buttons -->
  </IonTabBar>
</IonTabs>

After v8.3, any ion-tab-bar that was not a direct child of ion-tabs would lose it's expected behavior when used with a router outlet. If a user clicked on a tab button, then the content would not be redirected to that expected view.

React only:

Users can no longer add a ref to the IonRouterOutlet, it always returns undefined.

<IonTabs>
      <IonRouterOutlet ref={ref}>

     <IonTabBar slot="bottom">
    <!-- Buttons -->
  </IonTabBar>
</IonTabs>

What is the new behavior?

The fixes were already reviewed through PR #29925 and PR #29927. I split them to make it easier to review.

React and Vue:

The React tabs has been updated to pass data to the tab bar through context instead of passing it through a ref. By using a context, the data will be available for the tab bar to use regardless of its level.

React only:

Reverted the logic for routerOutletRef and added a comment of the importance of it.

Does this introduce a breaking change?

  • Yes
  • No

Other information

N/A

Copy link

vercel bot commented Oct 15, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
ionic-framework ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 16, 2024 3:14pm

@github-actions github-actions bot added package: vue @ionic/vue package package: react @ionic/react package labels Oct 15, 2024
@thetaPC thetaPC marked this pull request as ready for review October 16, 2024 17:38
@thetaPC thetaPC requested a review from a team as a code owner October 16, 2024 17:38
@thetaPC thetaPC requested a review from gnbm October 16, 2024 17:38
@thetaPC thetaPC added this pull request to the merge queue Oct 16, 2024
@brandyscarney brandyscarney removed this pull request from the merge queue due to a manual request Oct 16, 2024
@brandyscarney brandyscarney added this pull request to the merge queue Oct 16, 2024
Merged via the queue into main with commit b7b383b Oct 16, 2024
48 checks passed
@brandyscarney brandyscarney deleted the tabs-router-fixes branch October 16, 2024 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: react @ionic/react package package: vue @ionic/vue package
Projects
None yet
2 participants