fix(react): revert react output target version #29869
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
github-actions
bot
added
package: core
tanner-reits
commented
Sep 12, 2024
renovate.json5
Outdated
Comment on lines
17
to
30
| { | ||
| matchPackageNames: ["@stencil/react-output-target"], | ||
| matchFileNames: [ | ||
| "core/package.json" | ||
| ], | ||
| allowedVersions: ["<=0.5.3"] | ||
| }, | ||
| { | ||
| matchPackageNames: ["@stencil/core"], | ||
| matchFileNames: [ | ||
| "core/package.json" | ||
| ], | ||
| allowedVersions: ["<=4.20.0"] | ||
| }, |
There was a problem hiding this comment.
I think this will work to prevent these packages from updating, but hard to know until it merges and we let Renovate run 🤷♂️
There was a problem hiding this comment.
I'm also gonna create tasks for these respective issues so I'll add a comment with each of those task numbers once I have them
thetaPC
approved these changes
Sep 13, 2024
There was a problem hiding this comment.
LGTM, verified that the React test build still works and that both bugs from stencil-ds-output-targets are resolved.
However, I couldn't replicate this issue. I highly suggest asking the community to see if the dev build fixes their issue. If it does then we can change the PR description to resolve the issue: Issue number: ionic-team/stencil-ds-output-targets#476, ionic-team/stencil-ds-output-targets#475, #29848 to Issue number: ionic-team/stencil-ds-output-targets#476, ionic-team/stencil-ds-output-targets#475, resolves #29848
brandyscarney
approved these changes
Sep 13, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
brandyscarney
pushed a commit
that referenced
this pull request
Sep 17, 2024
Issue number: resolves ionic-team/stencil-ds-output-targets#476, resolves ionic-team/stencil-ds-output-targets#475, resolves #29848 --------- <!-- Please do not submit updates to dependencies unless it fixes an issue. --> <!-- Please try to limit your pull request to one type (bugfix, feature, etc). Submit multiple pull requests if needed. --> <!-- Please describe the current behavior that you are modifying. --> In v0.6.0 of the [React output target](https://www.npmjs.com/package/@stencil/react-output-target), the implementation was changed to leverage Lit's utility for creating React components from web components. This introduced some unforseen issues and breaking changes. <!-- Please describe the behavior or changes that are being added by this PR. --> - Reverts many of the changes from #29782 to downgrade the React output target package to the last stable version (v0.5.3) - Downgrades the version of Stencil to v4.20.0 (due to ionic-team/stencil#5983 causing problems with the downgraded output target) - Pins these versions and prevents Renovate from attempting to upgrade until the associated issues are resolved - [ ] Yes - [X] No <!-- If this introduces a breaking change: 1. Describe the impact and migration path for existing applications below. 2. Update the BREAKING.md file with the breaking change. 3. Add "BREAKING CHANGE: [...]" to the commit description when merging. See https://github.com/ionic-team/ionic-framework/blob/main/docs/CONTRIBUTING.md#footer for more information. --> <!-- Any other information that is important to this PR such as screenshots of how the component looks before and after the change. --> Dev build for this version: `8.3.1-dev.11726167750.15400355` I tested the dev build against the use cases outlined in ionic-team/stencil-ds-output-targets#475 and ionic-team/stencil-ds-output-targets#476
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number: resolves ionic-team/stencil-ds-output-targets#476, resolves ionic-team/stencil-ds-output-targets#475, resolves #29848
What is the current behavior?
In v0.6.0 of the React output target, the implementation was changed to leverage Lit's utility for creating React components from web components. This introduced some unforseen issues and breaking changes.
What is the new behavior?
Does this introduce a breaking change?
Other information
Dev build for this version:
8.3.1-dev.11726167750.15400355I tested the dev build against the use cases outlined in ionic-team/stencil-ds-output-targets#475 and ionic-team/stencil-ds-output-targets#476