fix(range, select): prefer labels passed by developer

[liamdebeasi]

Issue number: Internal

---

What is the current behavior?

With the removal of the legacy form syntax the team wanted to understand the value that getAriaLabel provides to determine if we still need this.

This utility was helpful for scenarios where developers provided their own label outside of the component. For example:

<div id="foo">Checkbox label</div>
<ion-checkbox aria-labelledby="foo"></ion-checkbox>

The challenge with this is the component isn't actually using aria-labelledby. We're grabbing the text content of #foo and setting it as an aria-label on the checkbox, so the flexibility here is fairly limited. The same goes for developers who want to use a <label> element and associated it with a component.

With the introduction of the modern form syntax labels should be provided directly on the form control (either via a visible text label or an aria-label). Additionally, this functionality was already removed from several components including checkbox. There has not been any community feedback for ~1.5 years which makes me think the patterns that getAriaLabel accounts for are not being used frequently.

Given that support for these patterns are a) do not seem to be used and b) are implemented inconsistently since only select and range support them, I propose we remove getAriaLabel altogether.

What is the new behavior?

• Ionic Framework will no longer automatically find external labels and apply them for developers. Developers can continue to achieve this behavior by manually applying an aria-label or visible text on the form control.
• Updated component guide to note how we handle form control labels now
• Removing this code uncovered an inconsistency in main where aria labels were effectively ignored when both visible text and an aria label is provided on range and select. I fixed this bug too.

Does this introduce a breaking change?

• Yes
• No

Rather than make this a new breaking change I've decided to update the select/range breaking changes to note this since this change is part of the modern form syntax updates.

Other information

[brandyscarney]

Works great! 👍