fix(checkbox): set aria-checked of indeterminate checkbox to 'mixed' #29115
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number: resolves Internal
What is the current behavior?
We are not ever explicitly setting
aria-checked
. For checked and unchecked states (i.e.true
andfalse
for aria-checked), we don't need to setaria-checked
because an input with a type of 'checkbox' has built-in semantics makingaria-checked
redundant.However, when the checkbox is in an indeterminate state,
aria-checked
should have a value of 'mixed'. We are not currently ever setting it to 'mixed'. See MDN for more details.What is the new behavior?
aria-checked
has a value of 'true' when it is checkedaria-checked
has a value of 'false' when it is uncheckedaria-checked
has a value of 'mixed' when it is indeterminateDoes this introduce a breaking change?
Other information