fix(overlays): tear down animations after dismiss

[mapsandapps]

Issue number: resolves #28352

---

What is the current behavior?

Not all animations are getting properly destroyed after they run. This means that styles can get stuck at the end value of their animation.

Specifically for this reproduction (as reported in the bug ticket), if the modal animates from 1 to 0 opacity and then the modal gets reopened with a different animation where the opacity should be 1 throughout (i.e. the opacity isn't supposed to animate at all), the modal is invisible because the opacity got stuck at 0 and never got reset to the default value of 1.

This bug is probably causing some incorrect behavior on other edge cases with overlays, but this is the only one I've identified.

Reproduction steps

Note: you cannot reproduce this when using a modalController

1. Open a modal, e.g. this one in ios mode on a screen wider than 768px
2. Close the modal
3. Open the same modal on a screen narrower than 768px
4. See that the modal does not appear

What is the new behavior?

• Animations are properly destroyed after the animation completes
• The modal now appears as expected after following the reproduction steps above

Does this introduce a breaking change?

• Yes
• No

[thetaPC]

LGTM

[sean-perkins]

Fantastic work 👏

[liamdebeasi]

Great job! I tested this in another app I was debugging, and it fixes one of the issues there as well.