Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(theme): export light theme tokens #28802

Merged
merged 8 commits into from
Jan 10, 2024
Merged

feat(theme): export light theme tokens #28802

merged 8 commits into from
Jan 10, 2024

Conversation

mapsandapps
Copy link
Contributor

@mapsandapps mapsandapps commented Jan 9, 2024

Issue number: Internal


What is the current behavior?

The light theme tokens are included in the starter apps but not in Ionic Framework itself.

What is the new behavior?

  • The light mode tokens are bundled with Ionic Framework. This allows developers to always have the light mode accessible to them including the tokens.

Does this introduce a breaking change?

  • Yes
  • No

Other information

@github-actions github-actions bot added the package: core @ionic/core package label Jan 9, 2024
@mapsandapps mapsandapps changed the base branch from feature-8.0 to st/datetime-background January 10, 2024 18:01
@mapsandapps mapsandapps changed the base branch from st/datetime-background to feature-8.0 January 10, 2024 19:27
@mapsandapps mapsandapps marked this pull request as ready for review January 10, 2024 21:51
@mapsandapps mapsandapps merged commit e1f9850 into feature-8.0 Jan 10, 2024
44 checks passed
@mapsandapps mapsandapps deleted the FW-5822 branch January 10, 2024 23:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: core @ionic/core package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants