feat(tab-button): update styles to iOS 17 specs #28754
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mapsandapps
requested review from
sean-perkins
and removed request for
a team
sean-perkins
approved these changes
Dec 27, 2023
There was a problem hiding this comment.
Font size for the label looks perfect when compared against the App Store tab bar:
Our icons are slightly smaller, but our icons in general have odd bounding boxes that will make it difficult to get a perfect fit for all icons with the same font size when compared against native.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number: Internal
What is the current behavior?
Tab Button icons on iOS are all 30px font size with or without a label.
What is the new behavior?
Does this introduce a breaking change?
Other information