feat(modal): update styles to iOS 17 specs #28748
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sean-perkins
requested review from
liamdebeasi
and removed request for
a team
This ratio better aligns with iPhone 15 (almost exact) and is only off by a few pixels as you scale to a Pro or Pro Max.
liamdebeasi
approved these changes
Dec 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number: Internal
What is the current behavior?
The card presentation of a presented view from a modal does not match iOS 17 design.
What is the new behavior?
0.91is the closest scale value.The iOS reference is from the Events app, when creating a new event. The Ionic reference is from the
modal/tests/cardexample in the repository (with the changes in this PR).Does this introduce a breaking change?
Other information