feat(action-sheet): add disabled button #28723
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liamdebeasi
commented
Dec 18, 2023
Comment on lines
+448
to
+449
| 'ion-activatable': !button.disabled, | ||
| 'ion-focusable': !button.disabled, |
There was a problem hiding this comment.
The design document recommended doing .action-sheet-button:not(:disabled).ion-activated (or ion-focused), but this seemed a bit cleaner by just removing the functionality altogether.
liamdebeasi
requested review from
averyjohnston
and removed request for
a team
sean-perkins
approved these changes
Dec 18, 2023
averyjohnston
approved these changes
Dec 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number: N/A
What is the current behavior?
Action sheet buttons cannot be disabled. This behavior exists in iOS 17.
What is the new behavior?
Does this introduce a breaking change?
Other information