Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: sheet modal backdrop animation is incorrect when backdropBreakpoint is 1 #25402

Closed
4 of 7 tasks
EinfachHans opened this issue Jun 3, 2022 · 6 comments
Closed
4 of 7 tasks
Labels
package: core @ionic/core package type: bug a confirmed bug report

Comments

@EinfachHans
Copy link
Contributor

Prerequisites

Ionic Framework Version

  • v4.x
  • v5.x
  • v6.x
  • Nightly

Current Behavior

When using a Sheet Style Modal with backdropBreakpoint: 1 the backdrop is buggy when the modal snaps back:

Expected Behavior

The backdrop should not be shown here of course

Steps to Reproduce

See attached Repo. Just drag the sheet down and release it

Code Reproduction URL

https://github.com/EinfachHans/ionic-sheet-modal-issue

Ionic Info

Ionic:

Ionic CLI : 6.19.1 (/Users/hans/.nvm/versions/node/v16.14.2/lib/node_modules/@ionic/cli)
Ionic Framework : @ionic/angular 6.1.8
@angular-devkit/build-angular : 13.2.6
@angular-devkit/schematics : 13.2.6
@angular/cli : 13.2.6
@ionic/angular-toolkit : 6.1.0

Capacitor:

Capacitor CLI : 3.5.1
@capacitor/android : not installed
@capacitor/core : 3.5.1
@capacitor/ios : not installed

Utility:

cordova-res (update available: 0.15.4) : 0.15.1
native-run : 1.6.0

System:

NodeJS : v16.14.2 (/Users/hans/.nvm/versions/node/v16.14.2/bin/node)
npm : 8.6.0
OS : macOS Monterey

Additional Information

No response

@ionitron-bot ionitron-bot bot added the triage label Jun 3, 2022
@sean-perkins sean-perkins self-assigned this Jun 6, 2022
@sean-perkins
Copy link
Contributor

Hello @EinfachHans can you describe the visual requirements of your app that caused you to use [backdropBreakpoint]="1" here?

It appears that you are wanting the background content to always be interact-able when the sheet modal is expanded. If this is the case, wouldn't you be using this with a combination of [showBackdrop]="false"?

Is the expectation that when using a value of 1, the sheet modal behaves as if the backdrop is not visible?

@sean-perkins sean-perkins added the needs: reply the issue needs a response from the user label Jun 6, 2022
@ionitron-bot ionitron-bot bot removed the triage label Jun 6, 2022
@EinfachHans
Copy link
Contributor Author

EinfachHans commented Jun 7, 2022

Hey @sean-perkins ,

yes that's right. Sheets are created very dynamically in our app and with the fact that in the future breakpointa may be reactive, i feel like this should work automatically.

@ionitron-bot ionitron-bot bot added triage and removed needs: reply the issue needs a response from the user labels Jun 7, 2022
@sean-perkins sean-perkins changed the title bug: sheet modal backdrop issue bug: sheet modal backdrop animation is incorrect when backdropBreakpoint is 1 Jun 7, 2022
@sean-perkins sean-perkins added package: core @ionic/core package type: bug a confirmed bug report labels Jun 7, 2022
@ionitron-bot ionitron-bot bot removed the triage label Jun 7, 2022
@sean-perkins
Copy link
Contributor

Thanks for the added detail! Can you test with this dev-build and let me know if the problem is resolved:

6.1.9-dev.11654617845.1b4d9725

Our calculation for the animation was evaluating to NaN, since 1 / 1 - backdropBreakpoint becomes Infinity.

@EinfachHans
Copy link
Contributor Author

@sean-perkins works 😊

@sean-perkins
Copy link
Contributor

Updated dev-build: 6.1.10-dev.11654886605.11e4eab6

Previous build had issues with transitions when using partial backdrop breakpoint values.

@ionitron-bot
Copy link

ionitron-bot bot commented Jul 13, 2022

Thanks for the issue! This issue is being locked to prevent comments that are not relevant to the original issue. If this is still an issue with the latest version of Ionic, please create a new issue and ensure the template is fully filled out.

@ionitron-bot ionitron-bot bot locked and limited conversation to collaborators Jul 13, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
package: core @ionic/core package type: bug a confirmed bug report
Projects
None yet
Development

No branches or pull requests

2 participants