Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to hide popup-buttons panel #2412

Closed
alextrs opened this issue Oct 17, 2014 · 3 comments
Closed

Allow to hide popup-buttons panel #2412

alextrs opened this issue Oct 17, 2014 · 3 comments

Comments

@alextrs
Copy link

alextrs commented Oct 17, 2014

Hello,

We want to be able to use our own set of buttons in popup, but currently $ionicPopup adds panel for buttons even if there are no buttons at all. We need it so we can conditionally disable / enable / hide / show buttons. Looks like it should be very minor change (not sure about backward compatibility)

Thank you,
Aliaks

@drewrygh
Copy link
Contributor

Confirmed, <div class='popup-buttons'> wrapper should be removed if no buttons are used. Thanks.

@drewrygh drewrygh added duplicate and removed ready labels Oct 22, 2014
@drewrygh
Copy link
Contributor

Just noticed this is a duplicate of #2344. You can follow the progress in that issue thread. Thanks!

@ionitron-bot
Copy link

ionitron-bot bot commented Sep 6, 2018

Thanks for the issue! This issue is being locked to prevent comments that are not relevant to the original issue. If this is still an issue with the latest version of Ionic, please create a new issue and ensure the template is fully filled out.

@ionitron-bot ionitron-bot bot locked and limited conversation to collaborators Sep 6, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants