Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Ionic v4] ion-slides missing event ionSlideTap #14859

Closed
peterpeterparker opened this issue Jul 25, 2018 · 5 comments
Closed

[Ionic v4] ion-slides missing event ionSlideTap #14859

peterpeterparker opened this issue Jul 25, 2018 · 5 comments
Labels

Comments

@peterpeterparker
Copy link
Contributor

Ionic Info
@ionic/angular: "4.0.0-alpha.12"

Describe the Feature Request
As in Ionic v3, ion-slides should provide the event ionSlideTap

Describe Alternatives
If this won't be implemented, a breaking change alternative should be provided

Related Code
https://github.com/ionic-team/ionic/blob/a7f1f4daa7166281f0735552b122d4c827cd20f1/core/src/components/slides/readme.md

@ionitron-bot ionitron-bot bot added the triage label Jul 25, 2018
@adamlacombe
Copy link
Contributor

I also noticed this. I've been working on a fix and will submit a pull request. It looks like the Swiper version was updated and some of the options have been renamed.

@krngd2
Copy link

krngd2 commented Jul 26, 2018

you can use (click) event

@peterpeterparker
Copy link
Contributor Author

@krngd2 thx that might be an alternative but @adamlacombe provided a PR which solves it, gonna wait for that first

@peterpeterparker
Copy link
Contributor Author

I just did forget to close this issue. Don't remember if it was solved in beta.1 or beta.2, but the PR of @adamlacombe totally solves it, ionSlideTap is back in v4

@ionitron-bot
Copy link

ionitron-bot bot commented Sep 11, 2018

Thanks for the issue! This issue is being locked to prevent comments that are not relevant to the original issue. If this is still an issue with the latest version of Ionic, please create a new issue and ensure the template is fully filled out.

@ionitron-bot ionitron-bot bot locked and limited conversation to collaborators Sep 11, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

3 participants