-
Notifications
You must be signed in to change notification settings - Fork 13.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ion-note is smaller when in a card #12646
Comments
Hello, thank you for opening an issue with us! I discussed this issue with one of our designers and the styling that you see is intentional. Using our SASS based theming infrastructure it is very easy to change any of those behaviors to meet your specific needs. Here is a link to one use case for the smaller text in the note when used in a card: http://ionicframework.com/docs/components/#card-advanced-social |
While intentional, there's an argument(s) to make that it's still incorrect. Since you're revisiting this similar issue, this one should be as well. The problem in each is the same; you've introduced inconsistent behavior depending on use case. Is there a spec to point to saying that notes in a card should be smaller than notes in a list? If not, the decision is arbitrary. Even if arbitrary, consistent behavior should be favored with options to alter the behavior. We shouldn't expect inconsistencies, and further expect to write custom code to resolve them. |
The size of the note should be the same for card & item in Material Design, but smaller than the item's label text: iOS keeps the font size the same as the item's label text and it doesn't have a "card" component similar to Material Design's: I spoke to @bensperry about this and here is what we need to do:
Let me know if you disagree with any of this, thanks! |
Are the two MD examples really a good starting point for a decision? They are both complicated/custom avatar examples with ~5 sub-details. In these cases, a shrunken note makes the most sense. A plain list, like the iOS example, is a far more common scenario. If we looked at that with MD styles, it might look odd were all the notes small, but as long as it's consistent. We need to find a comparably simple MD example to see if that's really the standard. |
Thanks for the issue! This issue is being locked to prevent comments that are not relevant to the original issue. If this is still an issue with the latest version of Ionic, please create a new issue and ensure the template is fully filled out. |
Ionic version: (check one with "x")
[x] 3.x
I'm submitting a ... (check one with "x")
[x] bug report
Current behavior:
An
ion-note
within a card is smaller than one outside. This seems inconsistent.Expected behavior:
I'd expect them to be the same, perhaps with an optional attribute (or custom css) to make them smaller.
Steps to reproduce:
http://plnkr.co/edit/zOOA0o99ul4S8NBLrrRl?p=preview
Related code:
Ionic info: (run
ionic info
from a terminal/cmd prompt and paste output below):The text was updated successfully, but these errors were encountered: